Bug 221775

Summary:	new USB Quirk for ROLAND Edirol PCR-300 MIDI keyboard [PATCH]
Product:	Base System	Reporter:	Thomas <thomas.masper>
Component:	usb	Assignee:	freebsd-usb (Nobody) <usb>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	hselasky
Priority:	---	Keywords:	patch
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Thomas 2017-08-24 19:38:26 UTC

MIDI Keyboard ROLAND Edirol PCR-300 [1] is not recognized by the system without adding the following quirk:

`--> svn diff sys/dev/usb/quirk/usb_quirk.c
Index: sys/dev/usb/quirk/usb_quirk.c
===================================================================
--- sys/dev/usb/quirk/usb_quirk.c	(revision 322815)
+++ sys/dev/usb/quirk/usb_quirk.c	(working copy)
@@ -507,6 +507,7 @@
 	USB_QUIRK(ROLAND, SD20, 0x0000, 0xffff, UQ_AU_VENDOR_CLASS),
 	USB_QUIRK(ROLAND, SD80, 0x0000, 0xffff, UQ_AU_VENDOR_CLASS),
 	USB_QUIRK(ROLAND, UA700, 0x0000, 0xffff, UQ_AU_VENDOR_CLASS),
+	USB_QUIRK(ROLAND, PCR300, 0x0000, 0xffff, UQ_AU_VENDOR_CLASS),
 	USB_QUIRK(EGO, M4U, 0x0000, 0xffff, UQ_SINGLE_CMD_MIDI),
 	USB_QUIRK(LOGILINK, U2M, 0x0000, 0xffff, UQ_SINGLE_CMD_MIDI),
 	USB_QUIRK(MEDELI, DD305, 0x0000, 0xffff, UQ_SINGLE_CMD_MIDI, UQ_MATCH_VENDOR_ONLY),

`--> svn diff sys/dev/usb/usbdevs
Index: sys/dev/usb/usbdevs
===================================================================
--- sys/dev/usb/usbdevs	(revision 322815)
+++ sys/dev/usb/usbdevs	(working copy)
@@ -3915,6 +3915,7 @@
 product ROLAND SD20		0x0027	SD-20 MIDI Synth
 product ROLAND SD80		0x0029	SD-80 MIDI Synth
 product ROLAND UA700		0x002b	UA-700 Audio I/F
+product ROLAND PCR300		0x0033  EDIROL PCR-300 MIDI I/F
 
 /* Rockfire products */
 product ROCKFIRE GAMEPAD	0x2033	gamepad 203USB


`--> sudo usbconfig -u 0 -a 2 dump_device_desc                    
ugen0.2: <EDIROL PCR> at usbus0, cfg=0 md=HOST spd=FULL (12Mbps) pwr=ON (300mA)

  bLength = 0x0012 
  bDescriptorType = 0x0001 
  bcdUSB = 0x0110 
  bDeviceClass = 0x00ff  <Vendor specific>
  bDeviceSubClass = 0x0000 
  bDeviceProtocol = 0x00ff 
  bMaxPacketSize0 = 0x0040 
  idVendor = 0x0582 
  idProduct = 0x0033 
  bcdDevice = 0x0100 
  iManufacturer = 0x0001  <EDIROL>
  iProduct = 0x0002  <PCR>
  iSerialNumber = 0x0000  <no string>
  bNumConfigurations = 0x0001 

Tested with Jack/Qsynth.

Thanks 
thomas

[1] https://www.roland.com/us/products/pcr-300/

Comment 1 Hans Petter Selasky freebsd_committer

2017-08-29 13:32:18 UTC

Patch looks good. --HPS

Comment 2 commit-hook freebsd_committer

2017-09-06 14:00:38 UTC

A commit references this bug:

Author: hselasky
Date: Wed Sep  6 13:59:57 UTC 2017
New revision: 323220
URL: https://svnweb.freebsd.org/changeset/base/323220

Log:
  Add new USB quirk.

  PR:			221775
  MFC after:		1 week
  Sponsored by:		Mellanox Technologies

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs

Comment 3 commit-hook freebsd_committer

2017-09-20 14:43:19 UTC

A commit references this bug:

Author: hselasky
Date: Wed Sep 20 14:42:21 UTC 2017
New revision: 323808
URL: https://svnweb.freebsd.org/changeset/base/323808

Log:
  MFC r322530 and r323220:
  Add new USB quirk(s).

  PR:			221328
  PR:			221775
  Sponsored by:		Mellanox Technologies

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/usbdevs

Comment 4 commit-hook freebsd_committer

2017-09-20 14:44:22 UTC

A commit references this bug:

Author: hselasky
Date: Wed Sep 20 14:43:55 UTC 2017
New revision: 323809
URL: https://svnweb.freebsd.org/changeset/base/323809

Log:
  MFC r322530 and r323220:
  Add new USB quirk(s).

  PR:			221775
  PR:			221328
  Sponsored by:		Mellanox Technologies

Changes:
_U  stable/10/
  stable/10/sys/dev/usb/quirk/usb_quirk.c
  stable/10/sys/dev/usb/usbdevs

Comment 5 commit-hook freebsd_committer

2017-09-20 14:47:30 UTC

A commit references this bug:

Author: hselasky
Date: Wed Sep 20 14:46:24 UTC 2017
New revision: 323810
URL: https://svnweb.freebsd.org/changeset/base/323810

Log:
  MFC r322530 and r323220:
  Add new USB quirk(s).

  PR:			221775
  PR:			221328
  Sponsored by:		Mellanox Technologies

Changes:
_U  stable/9/sys/
  stable/9/sys/dev/usb/quirk/usb_quirk.c
  stable/9/sys/dev/usb/usbdevs