Summary: | cad/stepcode: Fix portlint issues | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Fernando Apesteguía <fernape> | ||||||
Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | pi, w.schwarzenfeld | ||||||
Priority: | --- | Keywords: | easy | ||||||
Version: | Latest | Flags: | fernape:
merge-quarterly?
|
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 221836 | ||||||||
Attachments: |
|
portlint has this FATAL: FATAL: /home/pi/m/cad/stepcode/pkg-plist: [117]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /home/pi/m/cad/stepcode/pkg-plist: [118]: Man pages must be installed into ``man'' not ``share/man''. Why share/ ? (In reply to Kurt Jaeger from comment #1) I'm really sorry about that. I always check my patches with portlint and poudriere. The problem was that I used portlint-2.17.9 from quaterly branch and that version doesn't complain about anything in the port :S I updated to portlint-2.17.12 and fixed both the problems that you pointed out and a warning complaining about the relative order or USE_* and USES. For the new patch: Q/A: - portlint -AC: OK - poudriere builds for {10.3,11.0,11.1}{amd64,i386}: OK Created attachment 185886 [details]
patch to the ports tree V2
A commit references this bug: Author: pi Date: Tue Aug 29 19:36:17 UTC 2017 New revision: 448936 URL: https://svnweb.freebsd.org/changeset/ports/448936 Log: cad/stepcode: Fix portlint issues PR: 221835 Submitted by: Fernando Apesteguia <fernando.apesteguia@gmail.com> (maintainer) MFH: 2017Q3 Changes: head/cad/stepcode/Makefile head/cad/stepcode/files/ head/cad/stepcode/files/patch-doc_CMakeLists.txt head/cad/stepcode/pkg-plist A commit references this bug: Author: feld Date: Tue Sep 19 01:03:08 UTC 2017 New revision: 450086 URL: https://svnweb.freebsd.org/changeset/ports/450086 Log: MFH: r448936 cad/stepcode: Fix portlint issues PR: 221835 Submitted by: Fernando Apesteguia <fernando.apesteguia@gmail.com> (maintainer) Approved by: ports-secteam (with hat) Changes: _U branches/2017Q3/ branches/2017Q3/cad/stepcode/Makefile branches/2017Q3/cad/stepcode/files/ branches/2017Q3/cad/stepcode/pkg-plist Forgot to close? |
Created attachment 185786 [details] patch to the ports tree The attached patch fixes a couple of portlint issues: - Fixes order of PORTREVISION variable. - Fixes generation of manpages by setting proper MANDIRS value. It also bumps PORTREVISION. QA: - portlint -AC: OK - poudriere builds for {10.3,11.0,11.1}{amd64,i386}: OK