Bug 221898

Summary: [patch] adapt net/freerdp1 to new 'armv7' architecture
Product: Ports & Packages Reporter: Mark Linimon <linimon>
Component: Individual Port(s)Assignee: Mark Linimon <linimon>
Status: Closed FIXED    
Severity: Affects Some People Keywords: patch
Priority: --- Flags: kevans: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221894
Attachments:
Description Flags
patch to net/freerdp1 none

Description Mark Linimon freebsd_committer freebsd_triage 2017-08-29 12:14:09 UTC
Created attachment 185866 [details]
patch to net/freerdp1

The src tree is splitting 32-bit arm support into 'armv6' and the new 'armv7'.  This patch adds armv7 support.  It should provide no regression on any existing architecture.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-09-01 14:56:17 UTC
A commit references this bug:

Author: linimon
Date: Fri Sep  1 14:55:47 UTC 2017
New revision: 449084
URL: https://svnweb.freebsd.org/changeset/ports/449084

Log:
  The src tree is splitting 32-bit arm support into 'armv6' and the new
  'armv7'.  This patch adds armv7 support.  It should provide no regression
  on any existing architecture.

  PR:		221898
  Approved by:	maintainer

Changes:
  head/net/freerdp1/Makefile
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2017-09-01 15:02:56 UTC
Committed, thanks.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-09-01 15:48:26 UTC
Comment on attachment 185866 [details]
patch to net/freerdp1

>  OPTIONS_DEFINE_armv6=	NEON
> +OPTIONS_DEFINE_armv7=	NEON

Does armv7 (on FreeBSD) support NEON by default? If so adjust _DEFAULT options to not pessimize the binary package.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2017-09-09 16:51:17 UTC
(In reply to Jan Beich from comment #3)

I am currently traveling for the next few weeks and so someone else will need to investigate that.