Bug 221938
| Summary: | graphics/potrace: Update to 1.15, add support for building libpotrace | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Smyrak <ps.ports> | ||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | hrs, ps.ports, tobik, yuri | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
(In reply to Piotr Smyrak from comment #0) I'm curious why we have two ports graphics/potrace and graphics/libpotrace? Now that graphics/potrace also builds libpotrace can't they be one port? Before I forget, please use options helpers. This
+.include <bsd.port.options.mk>
...
+.if ${PORT_OPTIONS:MLIBRARY}
+USE_LDCONFIG+= yes
+USES+= libtool
+INSTALL_TARGET= install-strip
+PLIST_SUB+= LIBRARY=""
+.else
+PLIST_SUB+= LIBRARY="@comment "
+.endif
can be
OPTIONS_SUB= yes
LIBRARY_USE= LDCONFIG=yes
LIBRARY_USES= libtool
LIBRARY_INSTALL_TARGET= install-strip
Thanks for the tips. I was in contact with hrs@ and we agreed to merge them, when graphics/potrace gets library support. So I see this patch as a first stage. Created attachment 186006 [details]
port patch mk. 2
Any chance to get this integrated? Committed with changes. Sorry for the delay. Thank you for the update! A commit references this bug: Author: yuri Date: Thu Mar 8 08:55:15 UTC 2018 New revision: 463879 URL: https://svnweb.freebsd.org/changeset/ports/463879 Log: graphics/potrace: Update to 1.15 Port changes: * Changed DISTVERSION * Simplified MASTER_SITES * Added LIBRARY DOCS options * Moved plist into pkg-plist * Added CONFLICTS PR: 221938 Submitted by: Piotr Smyrak <ps.ports@smyrak.com> (maintainer) Approved by: tcberner (mentor, implicit) Changes: head/graphics/potrace/Makefile head/graphics/potrace/distinfo head/graphics/potrace/pkg-plist |
Created attachment 185921 [details] port patch Here's a patch that upgrades the port to recently released new version 1.15. Adds support for building library.