Summary: | www/midori: unbreak build with vala 0.36 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Carlos J. Puga Medina <cpm> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-xfce (Nobody) <xfce> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | cpm, duchateau.olivier, madpilot, xfce | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(xfce) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 221941 | ||||||||
Attachments: |
|
Description
Carlos J. Puga Medina
2017-09-03 08:00:53 UTC
Carlos, I don't understand your new patches about the 'ref' keyword. You pointed build log, but it doesn't show this error. In Vala the 'ref' (and 'out') keyword before a variable has meaning. Can you say more? (In reply to Olivier Duchateau from comment #1) Yes, other errors appear during compilation. That means there were more errors that didn't show up in the build log provided. Midori is successfully compiled after applying all patch files. http://sprunge.us/dFAF (In reply to Carlos J. Puga Medina from comment #2) Ok Created attachment 186080 [details]
patch
Update patch to make it compatible with current vala 0.30 version.
A commit references this bug: Author: madpilot Date: Wed Sep 27 12:19:28 UTC 2017 New revision: 450734 URL: https://svnweb.freebsd.org/changeset/ports/450734 Log: - Fix build with upcoming vala 0.36 [1] While here: - Indentition fixes - Silence portlint warning about variables ordering - Convert to USES=localbase PR: 222015 [1] Submitted by: cpm Changes: head/www/midori/Makefile head/www/midori/files/patch-config__search head/www/midori/files/patch-extensions__external-download-manager.vala head/www/midori/files/patch-extensions_adblock_widgets.vala head/www/midori/files/patch-extensions_apps.vala head/www/midori/files/patch-extensions_history-list.vala head/www/midori/files/patch-extensions_notes.vala head/www/midori/files/patch-extensions_transfers.vala head/www/midori/files/patch-midori_midori-notebook.vala Committed. Thanks! |