Bug 222021
| Summary: | [PATCH] databases/sqlite3: changed a options logic | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Pavel Volkov <pavelivolkov> | ||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||
| Severity: | Affects Some People | CC: | brnrd, pavelivolkov, swills, vsasjason | ||||||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||||||
| Version: | Latest | ||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||
| OS: | Any | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 186025 [details]
poudriere log
Sorry for the delay. It took me some time to understand the changes which are not documented in this PR. Here's the issues I found in this patch. 1. You changed RL from GROUP to SINGLE (1 among N). Since you add NONERL to RL, it means RL is a RADIO (0 or 1 among N). 2. You removed READLINES option and renamed READLINEP to READLINE. But READLINE option will not bring in devel/readline on FreeBSD 10.x since /usr/lib/libreadline.so is available. Feedback timeout. Back to pool. (In reply to Po-Chuan Hsieh from comment #3) Hello. Last times was a lot of work. I'm sorry for the delay. I'm working on the issues above. Created attachment 186829 [details] patch Hello. You right. Let's do it differently, better. Please, look at new patch. 1. Yes, I do it. 2. No. USES= readline automatically chooses what is the use: 'port' or 'base' version library. For 10.x it's - base library. It's as example: FreeBSD fb10.lan 10.4-RC2 FreeBSD 10.4-RC2 #0 r323928: Fri Sep 22 17:08:03 UTC 2017 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 /usr/local/bin/sqlite3: libreadline.so.8 => /lib/libreadline.so.8 (0x800956000) libncurses.so.8 => /lib/libncurses.so.8 (0x800b99000) libthr.so.3 => /lib/libthr.so.3 (0x800de6000) libc.so.7 => /lib/libc.so.7 (0x80100a000) Created attachment 186830 [details]
poudriere log
... and new poudriere log for 10.3.
Created attachment 187691 [details]
patch
New patch for new state, after upgrade the port to 3.21.
Created attachment 204625 [details]
slightly updated patch
Are these changes still relevant? I had to make one slight change to it, to change OPTIONS_GROUP_RL to OPTIONS_RADIO_RL. Can you confirm this is correct?
Created attachment 204777 [details]
change read/edit line logic
Sorry for the long wait. I slightly changed this patch.
And yes. The libedit system library is not allowed to use in /usr/ports/Mk/Script/qa.sh. I do not know why.
Thank you.
A commit references this bug: Author: brnrd Date: Sat Jul 11 20:23:00 UTC 2020 New revision: 542047 URL: https://svnweb.freebsd.org/changeset/ports/542047 Log: databases/sqlite3: change options logic PR: 222021 Submitted by: Pavel Volkov <pavelivolkov gmail com> Approved by: maintainer (pavelivolkov gmail com) Changes: head/databases/sqlite3/Makefile |
Created attachment 186024 [details] patch Changed a options for selecting the editing library.