Bug 222036

Summary: deskutils/go-for-it: unbreak build with vala 0.36
Product: Ports & Packages Reporter: Carlos J. Puga Medina <cpm>
Component: Individual Port(s)Assignee: Carlos J. Puga Medina <cpm>
Status: Closed FIXED    
Severity: Affects Many People CC: nc
Priority: --- Flags: nc: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 221941    
Attachments:
Description Flags
patch
none
patch cpm: maintainer-approval? (nc)

Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-03 22:00:40 UTC 
Created attachment 186043 [details]
patch

/wrkdirs/usr/ports/deskutils/go-for-it/work/Go-For-It-release_v1.5/src/TaskStore.vala:89.22-89.25: error: Argument 1: Cannot pass value to reference or output parameter
        this.remove (iter);
                     ^^^^

build log: http://package23.nyi.freebsd.org/data/110i386-default-PR221941/2017-08-31_07h56m24s/logs/go-for-it-1.5.log
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2017-09-04 13:31:21 UTC 
Seems good to me.
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-05 12:08:12 UTC 
Created attachment 186076 [details]
patch

Update patch to make it compatible with current vala 0.30 version.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-09-13 02:28:25 UTC 
A commit references this bug:

Author: cpm
Date: Wed Sep 13 02:27:37 UTC 2017
New revision: 449749
URL: https://svnweb.freebsd.org/changeset/ports/449749

Log:
  deskutils/go-for-it: unbreak build with vala 0.36

  /wrkdirs/usr/ports/deskutils/go-for-it/work/Go-For-It-release_v1.5/src/TaskStore.vala:89.22-89.25: error: Argument 1: Cannot pass value to reference or output parameter
          this.remove (iter);
                       ^^^^

  While I'm here, pet portlint, USE_* comes before USES

  PR:		222036
  Submitted by:	cpm
  Approved by:	Neel Chauhan <neel@neelc.org> (maintainer)

Changes:
  head/deskutils/go-for-it/Makefile
  head/deskutils/go-for-it/files/
  head/deskutils/go-for-it/files/patch-src_TaskStore.vala
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-13 02:29:12 UTC 
Committed!

Thanks