Bug 222067
| Summary: | [PATCH] www/nginx: fix for fastdfs module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Ylitalo <daniel> | ||||
| Component: | Individual Port(s) | Assignee: | Jochen Neumeister <joneum> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | joneum | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(joneum) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hey Daniel, thanks for the PR. I will have a look! :-) jochen Hi Daniel, what was the problem for the patch? Was there an error when starting ftp / fastdfs 5.0.11? You are currently the only person to report this Probably not that many using the fastdfs module to nginx other than me :) The problem is that nginx workers will crash if you load the fastdfs module with the default sample config as of fastdfs 5.0.11. The patch fixes the sample config so nginx will start with the installed sample-default values. The problem is that these 2 variables are added to fastdfs 5.0.11 which are missing from the sample config. http.default_content_type = application/octet-stream http.mime_types_filename=/usr/local/etc/nginx/mime.types When added with the patch nginx will start fine again. A commit references this bug: Author: joneum Date: Sat Oct 14 12:32:17 UTC 2017 New revision: 452061 URL: https://svnweb.freebsd.org/changeset/ports/452061 Log: - www/nginx: fix for fastdfs module - As of ftp/fastdfs 5.0.11 nginx wont start by default if the fastdfs module is loaded. Provided patch sorts that out by adding the missing params to the mod_fastdfs.conf file. While patching mod_fastdfs.conf i also changed the storage paths to match the ftp/fastds port PR: 222067 Reported by: Daniel Ylitalo <daniel@blodan.se> Approved by: miwi (mentor) MFH: 2017Q4 Differential Revision: https://reviews.freebsd.org/D12246 Changes: head/www/nginx/Makefile head/www/nginx/files/extra-patch-fastdfs-src-mod_fastdfs.conf A commit references this bug: Author: joneum Date: Tue Oct 17 07:19:45 UTC 2017 New revision: 452269 URL: https://svnweb.freebsd.org/changeset/ports/452269 Log: MFH: r452061 - www/nginx: fix for fastdfs module - As of ftp/fastdfs 5.0.11 nginx wont start by default if the fastdfs module is loaded. Provided patch sorts that out by adding the missing params to the mod_fastdfs.conf file. While patching mod_fastdfs.conf i also changed the storage paths to match the ftp/fastds port PR: 222067 Reported by: Daniel Ylitalo <daniel@blodan.se> Approved by: miwi (mentor) Differential Revision: https://reviews.freebsd.org/D12246 Approved by: ports-secteam (swills) Changes: _U branches/2017Q4/ branches/2017Q4/www/nginx/Makefile branches/2017Q4/www/nginx/files/extra-patch-fastdfs-src-mod_fastdfs.conf |
Created attachment 186078 [details] Config fix for fastdfs module As of ftp/fastdfs 5.0.11 nginx wont start by default if the fastdfs module is loaded. Provided patch sorts that out by adding the missing params to the mod_fastdfs.conf file. While patching mod_fastdfs.conf i also changed the storage paths to match the ftp/fastdfs port