Bug 222262

Summary: security/ca_root_nss: Add LICENSE_FILE
Product: Ports & Packages Reporter: Yasuhiro KIMURA <yasu>
Component: Individual Port(s)Assignee: Ports Security Team <ports-secteam>
Status: Open ---    
Severity: Affects Some People CC: jbeich, joneum
Priority: --- Flags: bugzilla: maintainer-feedback? (ports-secteam)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch file
none
updated patch file
none
updated patch file
none
Updated patch file
none
Updated patch file
none
Updated patch file none

Description Yasuhiro KIMURA 2017-09-12 15:47:15 UTC
Created attachment 186302 [details]
patch file

With developer mode 'make check-sanity' warns as following:

yasu@eastasia[3110]% pwd
/usr/ports/security/ca_root_nss
yasu@eastasia[3110]% make check-sanity DEVELOPER=yes
/!\ ca_root_nss-3.32.1: Makefile warnings, please consider fixing /!\

LICENSE must not contain MPL, instead use MPL[10|11|20]

===>  License MPL accepted by the user
yasu@eastasia[3111]% 

Attached patch fixes it.
Comment 1 Yasuhiro KIMURA 2017-09-13 01:29:04 UTC
Created attachment 186313 [details]
updated patch file

* Add "Created by" header.
* Add LICENSE_FILE.
* Remove NO_WRKSUBDIR and do-extract target because there isn't special reason requiring them.

So please commit attached patch instead of original one.
Comment 2 Yasuhiro KIMURA 2018-03-15 02:22:01 UTC
Created attachment 191510 [details]
updated patch file

Update patch to make it fit to latest ports tree. So please commit attached patch instead of previous ones.
Comment 3 Jochen Neumeister freebsd_committer 2019-02-15 18:24:42 UTC
what is the current status?
Does ports-secteam have to be active here?
Comment 4 Yasuhiro KIMURA 2019-02-15 18:37:50 UTC
Created attachment 202046 [details]
Updated patch file

Update patch to make it fit to latest ports tree.
Comment 5 Jochen Neumeister freebsd_committer 2019-02-15 18:41:18 UTC
Add @jbeich to the list.
He keeps this port up-to-date. I would like to hear his opinion.
Comment 6 Yasuhiro KIMURA 2019-02-15 18:44:00 UTC
Created attachment 202048 [details]
Updated patch file

Oops, Created-By header should not be restored.
Comment 7 Jan Beich freebsd_committer 2019-02-16 03:25:58 UTC
Comment on attachment 202048 [details]
Updated patch file

Looks OK to me.

Reviewed by:	jbeich

> +LICENSE_FILE=	${WRKSRC}/nss/COPYING
> -NO_WRKSUBDIR=	yes
> -CERTDATA_TXT_PATH=	nss-${VERSION_NSS}/nss/lib/ckfw/builtins/certdata.txt
> +CERTDATA_TXT_PATH=	nss/lib/ckfw/builtins/certdata.txt

Maybe dedup nss/ via WRKSRC_SUBDIR=nss like security/nss did. Upstream uses a subdirectory because NSS is sometimes distributed with NSPR bundled e.g.,

https://download.cdn.mozilla.net/pub/security/nss/releases/NSS_3_42_1_RTM/src/nss-3.42.1-with-nspr-4.20.tar.gz
Comment 8 Yasuhiro KIMURA 2019-02-16 07:10:24 UTC
Created attachment 202061 [details]
Updated patch file

Reflect Jan's feedback and fix some portlint warnings and stage-qa errors.