Bug 222290

Summary:	databases/phpmyadmin: removing mcrypt as default?
Product:	Ports & Packages	Reporter:	OlivierW <olivierw1+bugzilla-freebsd>
Component:	Individual Port(s)	Assignee:	Matthew Seaman <matthew>
Status:	Closed FIXED
Severity:	Affects Only Me	Flags:	matthew: maintainer-feedback+
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description OlivierW 2017-09-13 15:18:34 UTC

Hello,

In the options, both OPENSSL and MCRYPT are enabled by default.
PHP 7.1 and later are deprecating/removing MCRYPT ( http://php.net/manual/en/migration71.deprecated.php and https://wiki.php.net/rfc/mcrypt-viking-funeral )


I've read this PR from 2010: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=144983 but now OpenSSL is recommended by phpMyAdmin: https://github.com/phpmyadmin/phpmyadmin/pull/12273/files


This comment say OpenSSL is used in priority by phpseclib (used by phpmyadmin): https://github.com/phpseclib/phpseclib/issues/1028#issuecomment-242739527

Having the OPENSSL option already enabled by default, I think MCRYPT is useless even on PHP < 7.1. It should be safe to set the MCRYPT option to Off.

What do you think?

Comment 1 Matthew Seaman freebsd_committer

2017-09-13 15:31:12 UTC

Yes, I agree.  I shall remove the MCRYPT option tonight.

Comment 2 OlivierW 2017-09-13 16:57:24 UTC

Thanks Matthew!

Comment 3 Matthew Seaman freebsd_committer

2017-09-13 21:15:49 UTC

Committed, thanks!

Comment 4 commit-hook freebsd_committer

2017-09-13 21:16:24 UTC

A commit references this bug:

Author: matthew
Date: Wed Sep 13 21:15:27 UTC 2017
New revision: 449813
URL: https://svnweb.freebsd.org/changeset/ports/449813

Log:
  Drop the MCRYPT option.  MCRYPT has been deprecated by upstream PHP
  and the mcrypt project itself is abandonware.

  PR:		222290
  Reported by:	olivierw1+bugzilla-freebsd@hotmail.com

Changes:
  head/databases/phpmyadmin/Makefile