Bug 222472
| Summary: | java/intellij-ultimate: Update to 2017.2.5 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan <bsd> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Boris Samorodov <bsam> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | andoriyu, bsam, tablooaraz, ultima | ||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||
| Version: | Latest | Flags: | andoriyu:
maintainer-feedback+
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ivan
2017-09-20 14:39:23 UTC
(In reply to Ivan from comment #0) Yes, I will take care of it tomorrow. Are there any problems/can I help ? Maybe we can take necessary bits from intellij port ? The problem with current version built against current port tree that all default templates has disappeared, so I can't track current port tree anymore. intellij port has all templates in place, so maybe bump of intellij-ultimate to latest version will help. Thanks! Created attachment 187006 [details]
update
As I expected, version upgrade helped. I archived the patch as it's too big. LGTM. Sorry didn't get to it myself. Created attachment 187742 [details]
Patch to update it to 2017.2.5
Comment on attachment 187006 [details]
update
outdated
Please confirm the change passes QA (poudriere and portlint in particular) Created attachment 187773 [details]
Patch to update it to 2017.2.5
portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: save for ports directly related to the Java language, porters are encouraged not to use ``java'' as the main category for a port
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 3 warnings found.
When testing on 103i386, the following error is generated. /usr/bin/strip: /wrkdirs/usr/ports/java/intellij-ultimate/work/stage/usr/local/intellij/plugins/tfsIntegration/lib/native/freebsd/x86_64/libnative_synchronization.so: File format not recognized *** Error code 1 full log here: https://poudriere.ultimasbox.com/data/103i386-test/2017-11-11_16h48m10s/logs/errors/intellij-ultimate-2017.2.5.log (In reply to Richard Gallamore from comment #10) Suggestions: 1. Add ARCH amd64 2. Remove 64-bit binaries for i386 3. Don't strip stuff Created attachment 187974 [details]
Patch to update it to 2017.2.5
Removed stripping of native libraries like it was before.
MARKED AS SPAM Take. A commit references this bug: Author: bsam Date: Fri Dec 15 11:42:12 UTC 2017 New revision: 456392 URL: https://svnweb.freebsd.org/changeset/ports/456392 Log: java/intellij-ultimate: Update to 2017.2.5. PR: 222472 Submitted by: Ivan <bsd@abinet.ru> Patch by: Andrey Cherkashin <andoriyu@gmail.com> (maintainer) Changes: head/java/intellij-ultimate/Makefile head/java/intellij-ultimate/distinfo head/java/intellij-ultimate/pkg-plist Committed, thanks! As a side note: 1. There is a newer version available. 2. One may add my email to the CC list while open a PR about Jetbrans products. (In reply to Boris Samorodov from comment #16) Got it. Thank you! (In reply to Boris Samorodov from comment #16) Is there an easy way to generate pkg-plist for jetbrains products? TLDR; For me "make makeplist" does the hard part.
The longer version.
For a new port version I use "testport" poudriere command with interactive shell ("-i" option). When a shell prompt is invoked I use "make -C /usr/ports/whatever/port makeplist > /tmp/pkg-plist" command to create a raw pkg-plist version. Then (before closing the jail, i.e. before exitting from a shell) get this pkg-plist at the host (ex. $POUDRIERE_HOME/data/.m/103-amd64-testing/ref/tmp/pkg-plist). Fix it (sed command or smth else) and make it use.
That's it. ;-)
HTH & WBR, bsam
|
