Bug 222517
| Summary: | graphics/pngcrush: Update to 1.8.13 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Some People | CC: | vsasjason | ||||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||||
| Version: | Latest | Flags: | vsasjason:
maintainer-feedback+
|
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
lightside
2017-09-22 19:26:48 UTC
Created attachment 186619 [details]
Proposed patch (since 425824 revision)
Clarified sed patch, just in case.
Created attachment 186659 [details]
poudriere testport log on releng/11.1
Comment on attachment 186619 [details]
Proposed patch (since 425824 revision)
Looks ok for me. Note there is a warning about LICENSE - I plan to fix this later because I have not enough time currently.
Created attachment 186667 [details] Proposed patch (since 425824 revision, with license definition) (In reply to from comment #3) > Looks ok for me. Thanks for review. (In reply to from comment #3) > Note there is a warning about LICENSE Yes, I saw following warning from portlint output: WARN: Makefile: Consider defining LICENSE. Looks like, the pngcrush has a custom license. According to https://pmt.sourceforge.io/pngcrush/ -8<-- Pngcrush is open source and may be used, modified, and redistributed by anyone without paying a fee. The license, embedded in the file pngcrush.c, is equivalent but not identical to the libpng license found in the libpng file png.h. -->8- I attached new proposed patch with possible license definition. Please review it. I can remove/obsolete attachment #186619 [details] in case of possible approval of new patch. Suggestions are welcome. Comment on attachment 186667 [details] Proposed patch (since 425824 revision, with license definition) // It's better to reset maintainer-feedback to '?' to block possible commit. According to LICENSE file, pngcrush should be redistributed free in any form: > Permission is hereby irrevocably granted to everyone to use, copy, modify, and distribute this source code, or portions hereof, or executable programs compiled from it, for any purpose, ***without payment of any fee***, subject to the following restrictions: So I think that LICENSE_PERMS should be changed to "dist-mirror pkg-mirror auto-accept" Created attachment 186670 [details] Proposed patch (since 425824 revision) (In reply to comment #5) > So I think that LICENSE_PERMS should be changed to > "dist-mirror pkg-mirror auto-accept" Ok, done. Created attachment 186672 [details]
poudriere testport log on releng/11.1 (after adding LICENSE)
Comment on attachment 186670 [details]
Proposed patch (since 425824 revision)
Now it's fully ready to commit. Thanks for your work & port updating help!
A commit references this bug: Author: swills Date: Fri Sep 29 19:45:27 UTC 2017 New revision: 450933 URL: https://svnweb.freebsd.org/changeset/ports/450933 Log: graphics/pngcrush: Update to 1.8.13 PR: 222517 Submitted by: lightside <lightside@gmx.com> Approved by: Anton Sayetsky <vsasjason@gmail.com> (maintainer) Changes: head/graphics/pngcrush/Makefile head/graphics/pngcrush/distinfo head/graphics/pngcrush/files/ Committed, thanks! |
