Bug 222564

Summary:	misc/rump: fails to build with lang/gcc7 or later
Product:	Ports & Packages	Reporter:	Jan Beich <jbeich>
Component:	Individual Port(s)	Assignee:	Vanilla I. Shu <vanilla>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	gerald, vanilla
Priority:	---	Keywords:	needs-patch
Version:	Latest	Flags:	jbeich: maintainer-feedback? (vanilla)
Hardware:	Any
OS:	Any
Bug Depends on:
Bug Blocks:	222542

Description Jan Beich freebsd_committer

2017-09-24 17:32:07 UTC

$ echo "DEFAULT_VERSIONS += gcc=7" >>${__MAKE_CONF:-/etc/make.conf}
$ make
[...]
ndpool.c: In function 'rndpool_add_data':
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:184:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
    val = *buf++;
    ~~~~^~~~~~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:185:3: note: here
   case 2:
   ^~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:186:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
    val = val << 8 | *buf++;
    ~~~~^~~~~~~~~~~~~~~~~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:187:3: note: here
   case 1:
   ^~~~
cc1: all warnings being treated as errors

build log: http://sprunge.us/UZHA

Comment 1 Vanilla I. Shu freebsd_committer

2017-10-06 06:29:00 UTC

I add some patches to fix building with clang,

so do not require gcc anymore.