Bug 222585
| Summary: | [maintainer-update] lang/opencoarrays update to 1.9.3 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Anton Shterenlikht <as> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Tijl Coosemans <tijl> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | riggs, swills | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
(In reply to Anton Shterenlikht from comment #0) The "6.4.0" is most likely obtained from the GCC version string. Could you look into this? It's not good if the plist of a port changes because the compiler version string changes somewhere else in the ports tree. Sorry for the delay.
I need help.
As far as I can see the upstream does detailed checks for the Fortran
compiler version and gets 6.4.0. It then uses this string
in a path name:
-- Installing: /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6.4.0
-- Installing: /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6.4.0/opencoarrays.mod
However, all I have it GCC_VER which gives me just "6", so using
include/OpenCoarrays-1.9.2_GNU-%%GCC_VER%%/opencoarrays.mod
in pkg-plist gives this error:
===> Registering installation for opencoarrays-1.9.2_1
pkg-static: Unable to access file /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6/opencoarrays.mod:No such file or directory
So, the question - is there an easy way to set a var
in the Makefile to the full Fortran compiler version, e.g. 6.4.0?
If not, the only way I see is to overwrite the upstream's
file name with GCC_VER. I can probably do this e.g. with ${REINPLACE_CMD}.
Please advise
Thanks
Anton
(In reply to Anton Shterenlikht from comment #2) Probably the most clean solution is to locate where the compiler string is set in the build system and than patch is to simply not do that. (and proposing this as an upstream change) Created attachment 189611 [details]
lang/opencoarrays update to 1.9.3
seems to build and package fine.
All tests pass.
Created attachment 189655 [details]
lang/opencoarrays update to 1.9.3
previous patch was contaminated by unclean environment.
The new patch was checked with synth.
Created attachment 190806 [details]
Latest patch checked by tijl@
From tijl@: with FreeBSD 12 (r329260): All tests pass with both MPICH and OpenMPI.
With FreeBSD 11 I'm seeing some test failures.
Still, time to update the port.
A commit references this bug: Author: tijl Date: Mon Feb 19 18:04:11 UTC 2018 New revision: 462341 URL: https://svnweb.freebsd.org/changeset/ports/462341 Log: Update to 1.9.3. PR: 222585 Submitted by: Anton Shterenlikht <as@cmplx.uk> (maintainer) Changes: head/lang/opencoarrays/Makefile head/lang/opencoarrays/distinfo head/lang/opencoarrays/pkg-descr head/lang/opencoarrays/pkg-plist |
Created attachment 186694 [details] lang/opencoarrays svn diff - update from 1.9.1 to 1.9.2 Please check pkg-plist. I'm not sure if this change is right: -include/OpenCoarrays/GNU/%%GCC_VER%%/opencoarrays.mod +include/OpenCoarrays-1.9.2_GNU-6.4.0/opencoarrays.mod