Bug 222770
| Summary: | devel/ninja: Update to 1.8.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Grzegorz Blach <gblach> | ||||||
| Component: | Individual Port(s) | Assignee: | Grzegorz Blach <gblach> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | adridg, portmgr, rakuco, tcberner | ||||||
| Priority: | --- | Flags: | gblach:
exp-run?
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Grzegorz Blach
2017-10-04 08:26:06 UTC
Created attachment 186899 [details]
Update to 1.8.2
cc the CMake guys. 1 new failure on 10.3 amd64: devel/leatherman http://package22.nyi.freebsd.org/data/103amd64-default-PR222770/2017-10-06_08h38m01s/logs/errors/leatherman-1.3.0_2.log 1 new failure on 10.3 i386: devel/leaherman http://package23.nyi.freebsd.org/data/103i386-default-PR222770/2017-10-06_08h37m52s/logs/errors/leatherman-1.3.0_2.log 2 ports were not tested due to this failure Created attachment 186986 [details]
possible patch for devel/leatherman
Hi
attached is a patch for devel/leatherman that renames the gettext targets as not to coincide with the filenames.
mfg Tobias
A commit references this bug: Author: rakuco Date: Sat Oct 7 18:32:19 UTC 2017 New revision: 451472 URL: https://svnweb.freebsd.org/changeset/ports/451472 Log: Switch to an out-of-source CMake build. It does not have any bad side-effects, and out-of-source builds are recommended by CMake. In this case, it also avoids ninja warnings that become errors with Ninja 1.8: ninja: warning: multiple rules generate locales/leatherman.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate locale/locales/leatherman_locale.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate logging/locales/leatherman_logging.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] PR: 222770 Changes: head/devel/leatherman/Makefile (In reply to Tobias C. Berner from comment #4) > Created attachment 186986 [details] > possible patch for devel/leatherman > > Hi > > attached is a patch for devel/leatherman that renames the gettext targets as > not to coincide with the filenames. > > mfg Tobias Sorry for stepping on your toe, I didn't see the email and ended up finding a different fix... (In reply to Raphael Kubo da Costa from comment #6) Yours was the better fix, so no worries :) Exp-run looks fine. A commit references this bug: Author: gblach Date: Tue Oct 10 11:12:06 UTC 2017 New revision: 451661 URL: https://svnweb.freebsd.org/changeset/ports/451661 Log: Update to 1.8.2 PR: 222770 Reviewed by: antoine Changes: head/devel/ninja/Makefile head/devel/ninja/distinfo |