Bug 222964

Summary: devel/llvm50: clangd, libclangDemon.a should be in EXTRAS, not CLANG
Product: Ports & Packages Reporter: Laurence 'GreenReaper' Parry <greenreaper>
Component: Individual Port(s)Assignee: Brooks Davis <brooks>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (brooks)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pkg-plist patch which moves libclangDaemon.a to EXTRAS none

Description Laurence 'GreenReaper' Parry 2017-10-12 18:49:21 UTC 
Created attachment 187113 [details]
pkg-plist patch which moves libclangDaemon.a to EXTRAS

Clangd is listed as one of the clang "extras":
https://clang.llvm.org/extra/clangd.html

When compiling using portinstall with just CLANG, GOLD and OPENMP, I received the following install error:

===>   Installing ldconfig configuration file
--->  Installing the new version via the port
===>  Installing for llvm50-5.0.0_1
===>   llvm50-5.0.0_1 depends on package: perl5>=5.22<5.23 - found
===>   llvm50-5.0.0_1 depends on shared library: libedit.so.0 - found (/usr/local/lib/libedit.so.0)
===>   llvm50-5.0.0_1 depends on shared library: libxml2.so - found (/usr/local/lib/libxml2.so)
===>   Registering installation for llvm50-5.0.0_1
pkg-static: Unable to access file /tmp/usr/ports/devel/llvm50/work/stage/usr/local/llvm50/bin/clangd:No such file or directory
pkg-static: Unable to access file /tmp/usr/ports/devel/llvm50/work/stage/usr/local/llvm50/lib/libclangDaemon.a:No such file or directory
*** Error code 74

Stop.
make[2]: stopped in /usr/ports/devel/llvm50

The files in question are referenced in pkg-plist:

%%CLANG%%llvm%%LLVM_LIB_VER%%/bin/clangd
%%CLANG%%llvm%%LLVM_LIB_VER%%/lib/libclangDaemon.a

While it does not fail the installation, this installed shortcut doesn't work because the file in question does not exist; it should also be part of EXTRAS:

%%CLANG%%bin/clangd%%LLVM_SUFFIX%%
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-10-14 18:55:14 UTC 
A commit references this bug:

Author: brooks
Date: Sat Oct 14 18:54:52 UTC 2017
New revision: 452079
URL: https://svnweb.freebsd.org/changeset/ports/452079

Log:
  Fix build without EXTRAS (clangd is part of EXTRAS, not CLANG). [0]

  Update ccache links on install/deinstall. [1]

  PR:		222964 [0], 217572 [1]

Changes:
  head/devel/llvm50/Makefile
  head/devel/llvm50/pkg-plist