Bug 222994
| Summary: | Check for qt depends in LOCALBASE, not PREFIX | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||||||||
| Component: | Ports Framework | Assignee: | freebsd-kde (group) <kde> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | kargl, portmgr, ports-bugs | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://reviews.freebsd.org/D12666 | ||||||||||||
| Attachments: |
|
||||||||||||
The QT_*DIR part is not good, it is where lots of qt ports do install so it should be PREFIX not LOCALBASE. Also an exp-run won't show anything, we run them with PREFIX=LOCALBASE. (In reply to Antoine Brodin from comment #2) Ah. I hadn't thought that part through. May QT_*DIR should be eliminated and only QT_*DIR_REL allowed to solve the LOCALBASE/PREFIX confusion Created attachment 187157 [details]
v2
Only alter the checked paths, not the actual LIBDIR/BINDIR settings.
While I understand that the exp-run won't show whether it fixes PREFIX!=LOCALBASE, it'd at least be good to verify that it doesn't break anything.
(In reply to Antoine Brodin from comment #4) Does RUN_DEPENDS handle relative paths? I thought that it did a `which` for anything that doesn't start with a / or have a version specification. (In reply to Adam Weinberger from comment #6) I was suggesting using ${PREFIX}${QT_*REL} and ${LOCALBASE}${QT_*REL} everywhere Created attachment 187170 [details]
v3
Use the correct path for everything (${LOCALBASE}/${QT_*DIR_REL}) rather than subbing things in at the end.
(In reply to Adam Weinberger from comment #8) The charts_LIB and clucene_LIB lines shouldn't be changed Created attachment 187195 [details] v4 (In reply to Antoine Brodin from comment #9) Good catch! Fixed. This change looks fine to me. A commit references this bug: Author: adamw Date: Thu Oct 19 01:03:25 UTC 2017 New revision: 452391 URL: https://svnweb.freebsd.org/changeset/ports/452391 Log: Check for Qt depends in LOCALBASE, not PREFIX Qt has been looking for its dependencies in PREFIX, rather than in LOCALBASE. Dependencies are expected to exist in LOCALBASE, but PREFIX may be set arbitrarily by the end-user. When PREFIX != LOCALBASE, Qt-based ports failed to build. PR: 222994 Reported by: kargl Approved by: tcberner (kde) Exp-run by: antoine MFH: 2017Q4 Differential Revision: https://reviews.freebsd.org/D12666 Changes: head/Mk/bsd.qt.mk A commit references this bug: Author: adamw Date: Thu Oct 19 01:05:52 UTC 2017 New revision: 452392 URL: https://svnweb.freebsd.org/changeset/ports/452392 Log: MFH: r452391 Check for Qt depends in LOCALBASE, not PREFIX Qt has been looking for its dependencies in PREFIX, rather than in LOCALBASE. Dependencies are expected to exist in LOCALBASE, but PREFIX may be set arbitrarily by the end-user. When PREFIX != LOCALBASE, Qt-based ports failed to build. PR: 222994 Reported by: kargl Approved by: tcberner (kde) Exp-run by: antoine Differential Revision: https://reviews.freebsd.org/D12666 Approved by: ports-secteam (blanket, build fix) Changes: _U branches/2017Q4/ branches/2017Q4/Mk/bsd.qt.mk |
Created attachment 187153 [details] qt LOCALBASE Dependencies should be checked in LOCALBASE, not PREFIX. I'm not sure what the side effect of changing these variables is, so an exp-run would be elucidative.