Bug 223027

Summary: [patch] net/gnatsd: Improve rc script
Product: Ports & Packages Reporter: Romain Tartière <romain>
Component: Individual Port(s)Assignee: Jimmy Olgeni <olgeni>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: patch
Priority: --- Flags: bugzilla: maintainer-feedback? (olgeni)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix none

Description Romain Tartière freebsd_committer freebsd_triage 2017-10-15 11:25:53 UTC 
Created attachment 187193 [details]
Fix

Hey Jimmy!

The gnatsd init script has a "gnatsd_username" configuration setting.  This duplicates the gnatsd_user already provided by FreeBSD's init scripts systems: quoting rc.conf(5):

     ⟨name⟩_user
                 (str) Run the service under this user account.

The attached patch simplifies the script and fix this issue.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-10-15 12:32:58 UTC 
A commit references this bug:

Author: olgeni
Date: Sun Oct 15 12:32:49 UTC 2017
New revision: 452142
URL: https://svnweb.freebsd.org/changeset/ports/452142

Log:
  Replace gnatsd_username with gnatsd_user, which is already provided by rc.subr.

  PR:		223027
  Submitted by:   romain

Changes:
  head/net/gnatsd/Makefile
  head/net/gnatsd/files/gnatsd.sh.in
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2017-10-15 12:33:44 UTC 
Good catch - thanks!