Bug 223044

Summary: ftp/fastdfs: adding status command
Product: Ports & Packages Reporter: Daniel Ylitalo <daniel>
Component: Individual Port(s)Assignee: Danilo G. Baio <dbaio>
Status: Closed FIXED    
Severity: Affects Only Me CC: dbaio
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Adds fdfs_status command
daniel: maintainer-approval+
fastdfs-status.patch dbaio: maintainer-approval+

Description Daniel Ylitalo 2017-10-16 09:55:41 UTC
Created attachment 187210 [details]
Adds fdfs_status command

Provided patch adds a status command to easier monitor a cluster

Passes portlint -AC and poudriere testport
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2017-10-23 22:49:20 UTC
Hi Daniel.

Just a thought.

I even changed your patch [1] but now I am wondering, if isn't it better to send this request upstream? To simplify fdfs_monitor command output instead of creating this script?

[1] - https://dbaio.bs2cloud.com.br/FreeBSD/fastdfs-status.patch

Regards.
Comment 2 Daniel Ylitalo 2017-10-24 08:30:01 UTC
Hi!

It's not really easy to get something through upstream unfortunately :(

I already have 2 standing tickets of "real" bugs which havent gotten any attention at all.

Thanks for simplifying the patch, I would love if you could commit it.
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2017-11-04 20:46:11 UTC
Created attachment 187739 [details]
fastdfs-status.patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-11-04 21:35:47 UTC
A commit references this bug:

Author: dbaio
Date: Sat Nov  4 21:35:36 UTC 2017
New revision: 453488
URL: https://svnweb.freebsd.org/changeset/ports/453488

Log:
  ftp/fastdfs: Add status command

  It helps in monitoring a cluster more easily.

  While here, fix svn properties.

  PR:		223044
  Submitted by:	Daniel Ylitalo <daniel@blodan.se> (maintainer)

Changes:
  head/ftp/fastdfs/Makefile
_U  head/ftp/fastdfs/distinfo
  head/ftp/fastdfs/files/fdfs_status.in
_U  head/ftp/fastdfs/files/fdfs_storaged.in
_U  head/ftp/fastdfs/files/fdfs_trackerd.in
_U  head/ftp/fastdfs/files/patch-client-Makefile.in
_U  head/ftp/fastdfs/files/patch-conf-client.conf
_U  head/ftp/fastdfs/files/patch-conf-storage.conf
_U  head/ftp/fastdfs/files/patch-conf-tracker.conf
_U  head/ftp/fastdfs/files/patch-make.sh
_U  head/ftp/fastdfs/files/patch-storage-Makefile.in
_U  head/ftp/fastdfs/files/patch-tracker-Makefile.in
_U  head/ftp/fastdfs/pkg-descr
  head/ftp/fastdfs/pkg-plist
Comment 5 Danilo G. Baio freebsd_committer freebsd_triage 2017-11-04 21:44:34 UTC
Hi Daniel, sorry for the delay.

I had to consult another committer about this... the better is always submit an improvement upstream, but we understand that there are exceptions like this.

Thanks.