Bug 223108

Summary:

www/uwsgi: Add support for non-default Python versions, Take MAINTAINER'ship

Product:

Ports & Packages

Reporter:

schmidt

Component:

Individual Port(s)

Assignee:

freebsd-ports-bugs (Nobody) <ports-bugs>

Status:

Closed Overcome By Events

Severity:

Affects Only Me

CC:

koobs, python, schmidt

Priority:

---

Keywords:

needs-patch, needs-qa

Version:

Latest

Flags:

koobs: maintainer-feedback? (schmidt)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Update patch	none

Description schmidt 2017-10-19 09:20:29 UTC

Setting PYTHON_VERSION allows to build uwsgi agains a different python version than default python. Changed the package name accordingly to allow installation of multiple uWSGI Packages. 
Added rc.conf variable to select the executed binary. 

I would like to takeover maintainership of this port as I'm using it in production systems.

Comment 1 schmidt 2017-10-19 09:22:54 UTC

Created attachment 187300 [details]
Update patch

Comment 2 Kubilay Kocak freebsd_committer

2017-11-06 10:04:38 UTC

Thank you for your contribution Gerhard.

The attached patch needs changes, but I don't have time for a full review tonight.

Please run the port through portlint -AC and poudriere with DEVELOPER=yes enabled, and submit an updated patch which addresses any issues identified. For testing information and instructions, see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

Above that, some obvious issues:

- Remove PYTHON_PKGNAMEPREFIX from PORTNAME. For correct usage see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#using-python

- Use CHEESESHOP as MASTER_SITES by default unless there's a compelling temporary reason not to (eg: alternate source contains test files/test data)

- Use USE_PYTHON=autoplist
- Use USE_PYTHON=concurrent to do automatic suffixing of console scripts installed in LOCALBASE/bin

These are both documented in the link above as well.

- Explain the gettext-runtime addition

Lastly, thank you for offering to take maintainership of a FreeBSD port

Comment 3 schmidt 2017-11-16 06:49:48 UTC

I see that someone has already taken maintainership of this port i send him/her an updated patch for inclusion.