| Summary: | The file(1) utility is confused about dump dates | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Victor Sudakov <vas> | ||||
| Component: | bin | Assignee: | Oleksandr Tymoshenko <gonzo> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | cem, gonzo, vas | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | 10.4-RELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Victor Sudakov
2017-10-22 05:24:10 UTC
Ping Created attachment 194635 [details]
0001-Fix-order-of-previous-dump-and-this-dump-dates.patch
This looks like a bug in upstream. Dates order in sources is opposite: https://svnweb.freebsd.org/base/head/include/protocols/dumprestore.h?revision=326024&view=markup#l83 https://svnweb.freebsd.org/base/head/include/protocols/dumprestore.h?revision=326024&view=markup#l83 https://sourceforge.net/p/dump/code/ci/master/tree/compat/include/protocols/dumprestore.h#l90 I just sent a patch (attached) to file(1) developer. A commit references this bug: Author: gonzo Date: Tue Jun 26 18:53:52 UTC 2018 New revision: 335675 URL: https://svnweb.freebsd.org/changeset/base/335675 Log: Fix file(1) dumpdate reporting for dump(8) files Magic file for dump(8) had this dump and previous dump dates reversed. Fix order for all three flavours of the dump(8) format. This fix was committed to upstream repo as magic/Magdir/dump,v 1.17 and will be merged during next vendor import. PR: 223155 MFC after: 2 weeks Changes: head/contrib/file/magic/Magdir/dump A commit references this bug: Author: gonzo Date: Wed Jan 16 04:01:31 UTC 2019 New revision: 343079 URL: https://svnweb.freebsd.org/changeset/base/343079 Log: MFC r335675: Fix file(1) dumpdate reporting for dump(8) files Magic file for dump(8) had this dump and previous dump dates reversed. Fix order for all three flavours of the dump(8) format. This fix was committed to upstream repo as magic/Magdir/dump,v 1.17 and will be merged during next vendor import. PR: 223155 Changes: stable/11/contrib/file/magic/Magdir/dump |