Bug 223289 (qt5-rearm-webkit)

Summary:

[exp-run] armv6/v7 fixes to the Qt5 ports.

Product:

Ports & Packages

Reporter:

Tobias C. Berner <tcberner>

Component:

Individual Port(s)

Assignee:

Tobias C. Berner <tcberner>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

kde, linimon

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

URL:

https://reviews.freebsd.org/D12816

Bug Depends on:

Bug Blocks:

216816, 222612

Attachments:

Description	Flags
Fix build on armv6/v7 v1	none

Description Tobias C. Berner freebsd_committer

2017-10-28 16:36:39 UTC

Created attachment 187541 [details]
Fix build on armv6/v7 v1

Hi there

kde@ would like to ask for an exp-run of a patch obtained from
* ports pr 222612
* ports pr 216816

The patch is attached, and can also be found here:
http://people.freebsd.org/~tcberner/patches/qt5-arm-fixes.v1.patch

Thanks.

mfg Tobias

Comment 1 Antoine Brodin freebsd_committer

2017-10-28 16:53:37 UTC

Should the exp-run be done on amd64/i386?  We don't do exp-runs on arm.

Comment 2 Tobias C. Berner freebsd_committer

2017-10-28 17:03:03 UTC

Yes please, as we changes CXX flags during the test, I want to be sure, that it still builds fine on these architectures.

Comment 3 Antoine Brodin freebsd_committer

2017-10-30 09:34:36 UTC

Exp-run looks fine.

Comment 4 commit-hook freebsd_committer

2017-11-03 18:06:32 UTC

A commit references this bug:

Author: tcberner
Date: Fri Nov  3 18:06:16 UTC 2017
New revision: 453418
URL: https://svnweb.freebsd.org/changeset/ports/453418

Log:
  Fix qt5 builds on some arm architectures

  * 222612: www/qt5-webkit: for armv6/v7: The cacheFlush support is missing on this platform
  * 216816: devel/qt5: In arch.test, use CXXFLAGS from make environment

  PR:		222612,216816, 223289
  Exp-run by:	antoine
  Submitted by:	mmel, mikael.urankar@gmail.com
  Reported by:	Mark Millard <markmi@dsl-only.net>, mmel
  Reviewed by:	mmel, mikael.urankar@gmail.com
  Differential Revision:	https://reviews.freebsd.org/D12816

Changes:
  head/Mk/bsd.qt.mk
  head/devel/qt5/files/extrapatch-config.tests_unix_arch.test
  head/www/qt5-webkit/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h
  head/www/qt5-webkit/files/patch-Source_JavaScriptCore_assembler_ARMv7Assembler.h
  head/www/qt5-webkit/files/patch-Source_JavaScriptCore_offlineasm_arm.rb
  head/www/qt5-webkit/files/patch-Source_WTF_wtf_Platform.h
  head/www/qt5-webkit/files/patch-Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp
  head/www/qt5-webkit/files/patch-Source_bmalloc_bmalloc_BPlatform.h

Comment 5 Tobias C. Berner freebsd_committer

2017-11-03 18:07:46 UTC

Thanks for the exp-run.