Bug 223311
| Summary: | benchmarks/netperfmeter: Update to 1.7.6 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Thomas Dreibholz <thomas.dreibholz> | ||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | tcberner, tobik | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://www.uni-due.de/~be0001/netperfmeter/ | ||||||||
| Attachments: |
|
||||||||
Hi there 1) You can drop the check for FreeBSD 7 -- the FreeBSD ports do not support these outdated versions any ways. 2) The header of the Makefile looks rather non-standard :) 3) You can run portlint [ports-mgmt/portlint], which will give you various hints on how to make your Makefile conform to the standards of the tree somewhat more :) mfg Tobias Created attachment 187591 [details]
The updated diff file
The problems should be fixed in the updated diff.
That already looks great \o/. Can you double check and try to correct the man-installation path? :) You can probably also get rid of GNU_CONFIGURE, and use cmake:outsource :) -- to get the proper man paths you can do something like -SET(CMAKE_INSTALL_MANDIR "share/man" +SET(CMAKE_INSTALL_MANDIR "man" in the CMakeLists.txt mfg Tobias A commit references this bug: Author: tobik Date: Sun Mar 11 14:10:01 UTC 2018 New revision: 464174 URL: https://svnweb.freebsd.org/changeset/ports/464174 Log: benchmarks/netperfmeter: Update to 1.7.6 PR: 223311 Submitted by: dreibh@iem.uni-due.de (maintainer) Reviewed by: tcberner Changes: head/benchmarks/netperfmeter/Makefile head/benchmarks/netperfmeter/distinfo head/benchmarks/netperfmeter/pkg-descr head/benchmarks/netperfmeter/pkg-plist Committed with some changes. Thanks! It might be a good idea to teach the upstream project about CMake's GNUInstallDirs and CMAKE_INSTALL_MANDIR [1] to install the man pages into the right directory. [1] https://cmake.org/cmake/help/v3.11/module/GNUInstallDirs.html |
Created attachment 187569 [details] The diff to update the netperfmeter port The latest upstream version of net/rsplib is 1.7.6; the port needs an update. Fix: The updated diff file is attached.