Bug 223316

Summary: math/maxima: Update to 5.41.0
Product: Ports & Packages Reporter: satosi.kimura
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: tcberner
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch of modified maxima port
none
log of poudriere
none
modified patch
none
modified patch for distinfo none

Description satosi.kimura 2017-10-30 00:36:26 UTC
Created attachment 187576 [details]
patch of modified maxima port

I could install the latest maxima (5.41.0) to FreeBSD/amd64 10.4.

1. check by portlint
# portlint
WARN: Makefile: wrong dependency value for BUILD_DEPENDS. BUILD_DEPENDS requires 2 or 3 colon-separated tuples.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
0 fatal errors and 2 warnings found.

2. check by poudriere
 Decompress and see maxima-5.41.0_1.log.gz shown as attachment.
# gzip -d maxima-5.41.0_1.log.gz
Comment 1 satosi.kimura 2017-10-30 00:37:22 UTC
Created attachment 187577 [details]
log of poudriere
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-30 05:34:37 UTC
Moin moin 

You can remove the PORTREVISION when you increment the PORTVERSION.

mfg Tobias
Comment 3 satosi.kimura 2017-10-30 13:54:56 UTC
(In reply to Tobias C. Berner from comment #2)

 I see. I send modified patch.
Result of new patch is as follows:

% pkg info | grep maxima
maxima-5.41.0                  Symbolic mathematics program
Comment 4 satosi.kimura 2017-10-30 13:56:09 UTC
Created attachment 187584 [details]
modified patch
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2017-12-08 11:37:33 UTC
distinfo lacks TIMESTAMP. Also, why don't we switch to PORTDATA=* and simplify the plist?
Comment 6 satosi.kimura 2017-12-10 08:37:44 UTC
(In reply to Dmitry Marakasov from comment #5)

> distinfo lacks TIMESTAMP.
 I'm sorry. I did not think TIMESTAMP is essential.
I send modified patch only for distinfo.

> why don't we switch to PORTDATA=* and simplify the plist?
 I did not know the style making use of PORTDATA.
Now, I attempt to use PORTDATA, but it's not easy.
Please wait one more week or so.
Comment 7 satosi.kimura 2017-12-10 08:38:47 UTC
Created attachment 188681 [details]
modified patch for distinfo
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2017-12-11 16:52:59 UTC
(In reply to satosi.kimura from comment #6)
> (In reply to Dmitry Marakasov from comment #5)
> 
> > distinfo lacks TIMESTAMP.
>  I'm sorry. I did not think TIMESTAMP is essential.
> I send modified patch only for distinfo.

Next time please submit complete updated patch.

> > why don't we switch to PORTDATA=* and simplify the plist?
>  I did not know the style making use of PORTDATA.
> Now, I attempt to use PORTDATA, but it's not easy.
> Please wait one more week or so.

It's as easy as adding PORTDATA=* to Makefile and removing everything %%DATADIR%% from plist.

Committed with some additional improvements.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-12-11 16:53:30 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Dec 11 16:52:57 UTC 2017
New revision: 456049
URL: https://svnweb.freebsd.org/changeset/ports/456049

Log:
  - Update to 5.41.0 [1]
  - Add LICENSE_FILE
  - Whitespace fixes
  - Switch to new test framework

  PR:		223316 [1]
  Submitted by:	satosi.kimura@nifty.ne.jp [1]

Changes:
  head/math/maxima/Makefile
  head/math/maxima/distinfo
  head/math/maxima/pkg-plist