Bug 223357
| Summary: | sysutils/uefi-edk2-bhyve: build failure on python 3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Charlie Li <vishwin> | ||||
| Component: | Individual Port(s) | Assignee: | Roman Bogorodskiy <novel> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | fabian.freyer, novel | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(fabian.freyer) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Additionally, this port actually fails to build when DEFAULT_VERSIONS contains python=3.x. Relevant snippet from build log:
gmake -C Tests
gmake[2]: Entering directory '/wrkdirs/usr/ports/sysutils/uefi-edk2-bhyve/work/uefi-edk2-a36132939e259df79b16699c03c6f1d63c7454b9/BaseTools/Tests'
Traceback (most recent call last):
File "RunTests.py", line 22, in <module>
import TestTools
File "/wrkdirs/usr/ports/sysutils/uefi-edk2-bhyve/work/uefi-edk2-a36132939e259df79b16699c03c6f1d63c7454b9/BaseTools/Tests/TestTools.py", line 87
print description, '(base64 encoded):'
^
SyntaxError: invalid syntax
gmake[2]: *** [GNUmakefile:17: test] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/sysutils/uefi-edk2-bhyve/work/uefi-edk2-a36132939e259df79b16699c03c6f1d63c7454b9/BaseTools/Tests'
gmake[1]: *** [GNUmakefile:25: Tests] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/sysutils/uefi-edk2-bhyve/work/uefi-edk2-a36132939e259df79b16699c03c6f1d63c7454b9/BaseTools'
*** Error code 2
Stop.
make: stopped in /usr/ports/sysutils/uefi-edk2-bhyve
I would patch this file, but there is no telling where else in the source tree contains python2-isms.
A commit references this bug: Author: novel Date: Mon Nov 6 15:28:52 UTC 2017 New revision: 453624 URL: https://svnweb.freebsd.org/changeset/ports/453624 Log: sysutils/uefi-edk2-bhyve: stick to python2.7 Restrict python dependency to 2.7 as it fails to build with 3.x PR: 223357 Submitted by: Charlie Li Approved by: just-fix-it-blanket Changes: head/sysutils/uefi-edk2-bhyve/Makefile Committed, thanks! |
Created attachment 187637 [details] patch to explicitly set python2 in USES On systems where DEFAULT_VERSIONS includes a python set to any version in the 3.x series, the build fails in the build-depends phase. This stems from the databases/py-sqlite3 dependency that explicitly builds (currently) for python2. This patch explicitly specifies python2 as a build dependency for those systems with a python3 DEFAULT_VERSIONS.