Summary: | textproc/ripgrep: Restore shell completion options broken by previous SIMD options patch | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Petteri Valkonen <petteri.valkonen> | ||||
Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | tobik | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
(In reply to petteri.valkonen from comment #0) Committed. Thanks! I moved the options just before post-patch though since that's the position they should be in according to [1]. If a committer broke your port, please feel free to either mention it in the PR (even when it's closed) or if you create a new bug CC them. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html A commit references this bug: Author: tobik Date: Sat Nov 11 19:01:56 UTC 2017 New revision: 453990 URL: https://svnweb.freebsd.org/changeset/ports/453990 Log: textproc/ripgrep: Restore BASH, FISH, ZSH options They were broken by r453382 which introduced new AVX, SIMD options which overwrote the old ones. PR: 223478, 223314 Submitted by: petteri.valkonen@iki.fi (maintainer) Changes: head/textproc/ripgrep/Makefile |
Created attachment 187802 [details] Fix for shell completion config options The shell completion config options for Bash, Fish and ZSH were broken by the previous patch, which exposed SIMD options. The attached patch fixes the regression introduced in PR 223314.