Summary: | ports-mgmt/portlint: Don't warn about INSTALLS_ICONS when the project isn't GTK+ | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | adridg, rakuco, tcberner | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Yuri Victorovich
2017-11-07 18:51:11 UTC
Another thing is that the warning is printed a lot of times. One time is enough. Created attachment 188072 [details]
Patch to suppress INSTALLS_ICONS warning for Qt5 ports
This patch adds a `needs_installs_icons()` which states whether a port needs INSTALLS_ICONS when there are icons present. It's pessimistic, to preserve existing warnings and only suppress the warning for Qt5-based applications.
Additionally, checks for INSTALLS_ICONS when it isn't needed (i.e. Qt5).
The `needs_installs_icons()` function could be massaged to really check only for GNOME ports, but this seems simpler.
Adding tcberner@ (mentor for me and yuri) and rakuco@ (mentor for me). This sounds like a good idea. Fix committed to my repo pending the next release. Committed, thanks! |