Bug 223536

Summary: www/yarn: Add support for www/node8 now that www/node is v.9
Product: Ports & Packages Reporter: Daniel Ylitalo <daniel>
Component: Individual Port(s)Assignee: Luca Pizzamiglio <pizzamig>
Status: Closed FIXED    
Severity: Affects Only Me CC: bhughes, pizzamig
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Adds support for www/node8 none

Description Daniel Ylitalo 2017-11-08 14:01:44 UTC
Created attachment 187859 [details]
Adds support for www/node8

The provided patch adds support for the now created www/node8 port

Passes poudriere testport
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-11-09 16:56:35 UTC
A commit references this bug:

Author: pizzamig
Date: Thu Nov  9 16:55:36 UTC 2017
New revision: 453849
URL: https://svnweb.freebsd.org/changeset/ports/453849

Log:
  www/yarn: Add support to www/node8

  Moreover, adopt www/node8 as default option.

  PR:		223536
  Submitted by:	daniel@blodan.se
  Approved by:	olivier (mentor)
  Sponsored by:	trivago N.V.
  Differential Revision:	https://reviews.freebsd.org/D13006

Changes:
  head/www/yarn/Makefile
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-09 16:58:27 UTC
Thanks for the contribution.

I reworked the patch a little to be aligned with npm.
The default option is now NODE8, like in npm.
For this reason, I bumped the portrevision
Comment 3 Daniel Ylitalo 2017-11-09 17:14:22 UTC
Hi,

Just for your information, www/npm uses node 9.1 as default version (www/node) so you now made yarn inconsistent with the npm port :)
Comment 4 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-09 17:26:34 UTC
(In reply to Daniel Ylitalo from comment #3)

That's partially true.
I did it to be consistent with your patch on www/npm.
Currently, www/npm has as DEFAULT_OPTIONS NODE8, even if is still pointing to www/node.

When your patch on www/npm will be applied, it will be consistent again.