Bug 223575

Summary:	vnic: implement non-promiscuous mode
Product:	Base System	Reporter:	Ed Maste <emaste>
Component:	kern	Assignee:	freebsd-arm (Nobody) <freebsd-arm>
Status:	Open ---
Severity:	Affects Only Me	Keywords:	ThunderX
Priority:	---
Version:	CURRENT
Hardware:	Any
OS:	Any
Bug Depends on:
Bug Blocks:	231027

Description Ed Maste freebsd_committer

2017-11-09 20:54:30 UTC

See https://svnweb.freebsd.org/base/head/sys/dev/vnic/thunder_bgx.c?view=markup#l873 and BGX_IN_PROMISCUOUS_MODE - ThunderX VNIC driver supports only promiscuous mode right now (reject patches that match the MAC CAM filter, accept all multicast and all broadcast).

Comment 1 Eitan Adler freebsd_committer

2018-05-28 19:43:32 UTC

batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.

Comment 2 Ed Maste freebsd_committer

2018-08-30 16:45:44 UTC

Move to 13.x tracking PR - if we're able to take on work for the Cavium Octeon TX family (i.e., basically embedded ThunderX) this issue will be investigated as part of that work.

Comment 3 commit-hook freebsd_committer

2019-09-01 16:53:37 UTC

A commit references this bug:

Author: emaste
Date: Sun Sep  1 16:53:17 UTC 2019
New revision: 351664
URL: https://svnweb.freebsd.org/changeset/base/351664

Log:
  vnic: correct and simplify SIOCSIFFLAGS

  PR:		223573, 223575
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D13028

Changes:
  head/sys/dev/vnic/nicvf_main.c

Comment 4 commit-hook freebsd_committer

2021-07-28 00:09:41 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=941650aae9762293f4c63788ddb17e0114828813

commit 941650aae9762293f4c63788ddb17e0114828813
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-07-27 21:51:21 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-07-28 00:09:01 +0000

    vnic: add TODO list item for non-promisc mode

    Also drop ARM64TODO comments; this is an issue with this specific
    driver, not a general arm64 issue.

    PR:             223575

 sys/dev/vnic/nic_main.c   | 11 +++++++++++
 sys/dev/vnic/nicvf_main.c |  6 ++----
 2 files changed, 13 insertions(+), 4 deletions(-)

Comment 5 commit-hook freebsd_committer

2022-02-12 19:10:50 UTC

A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a60685ffbc743e417972390ce6674ce38918a115

commit a60685ffbc743e417972390ce6674ce38918a115
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-07-27 21:51:21 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-02-12 19:09:52 +0000

    vnic: add TODO list

    - non-promisc mode
    - multicast filter support

    Also drop ARM64TODO comments; this is an issue with this specific
    driver, not a general arm64 issue.

    PR:             223575
    PR:             223573

    (cherry picked from commit 941650aae9762293f4c63788ddb17e0114828813)
    (cherry picked from commit 29e9b487c1d427409a8bf1f893bc71a57c76f4b0)

 sys/dev/vnic/nic_main.c   | 12 ++++++++++++
 sys/dev/vnic/nicvf_main.c |  6 ++----
 2 files changed, 14 insertions(+), 4 deletions(-)