Bug 223721
| Summary: | textproc/htmldoc: [PATCH] Update to 1.9.3 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Zsolt Udvari <uzsolt> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | delphij, jose, ndowens04, riggs, sbruno | ||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(jose) |
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228944 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Zsolt Udvari
2017-11-17 17:13:23 UTC
I've got a patch ready, doing QA on it currently Created attachment 196490 [details] Update textproc/htmldoc: * Update to 1.9.3 * Rearranged Options -- Makes it easier to find them * Removed jpeg from USES -- Only needed if HTMLDOCGUI is enabled -- Added it to OPTION if enabled * Removed previous configure_args -- Builds fine, even with gnutls enabled * Used ${REINPLACE_CMD} if arch is arm64 -- arm64 does't support png neon support Changelog: https://github.com/michaelrsweet/htmldoc/blob/master/CHANGES.md (In reply to Nathan from comment #2) Tested in poudriere(amd64) 11.2 10.4 poudriere(i386) 11.2 poudriere(armv6) poudriere(arm64) Above built fine, but not mips Also tested on 12-current jail and built fine as well so i think it will also fix 228944 Add bugs claimed to be resolved by this bug at Nathans request. @Nathan please confirm (explicitly, here) that this update fixes (confirmed to build with openssl 1.1 successfully in poudriere) bug 228944 It built fine for me. The only thing I’m unsure of is if the build is enabling ssl. Hoping to get others to test it. I DO know it’s building fine but would like confirmation if SSL is working or not as the following is in configure run: configure: Using SSLFLAGS="", SSLLIBS="" (In reply to Nathan from comment #6) Update. I’m thinking ssl isn’t being used atm. Gonna be working on fixing the issue Created attachment 196508 [details]
Update
Seems SSL is enabled if GNUTLS is installed, atleast the library. Need people with 12-current to test this. I tried testing in my 12-current jail but it fails building with python
(In reply to Nathan from comment #8) Update, according to upstream, openssl is not supported: https://github.com/michaelrsweet/htmldoc/issues/336#event-1808757060 Bug #228944 will not apply after this update Created attachment 196513 [details]
Update; Fix SSL(GNUTLS)
Added pkgconfig, so gnutls will be found
Created attachment 196557 [details]
Patch rebased over 478107
(In reply to Xin LI from comment #11) *sigh* Sorry to ask this, but the Makefile seems to fail to patch. I'd update it myself, but its a bit more complicated than I'm comfortable with. Can you regenerate it? (In reply to Sean Bruno from comment #12) I thought the conflict might be caused by the s/openssl-devel/openssl111/g change, if you apply on that, will it allow you to apply the patch cleanly? I can take a look later time tonight. A commit references this bug: Author: swills Date: Sun Dec 9 02:48:32 UTC 2018 New revision: 487012 URL: https://svnweb.freebsd.org/changeset/ports/487012 Log: textproc/htmldoc: Update to 1.9.3 PR: 223721 Submitted by: Nathan <ndowens@yahoo.com> Submitted by: delphij Reported by: Zsolt Udvari <uzsolt@uzsolt.hu> Changes: head/textproc/htmldoc/Makefile head/textproc/htmldoc/distinfo head/textproc/htmldoc/files/ head/textproc/htmldoc/pkg-descr Committed, forgot to mention the maintainer timeout in the commit, sorry. Thanks for the patch! |