Summary: | net/freerdp: enable Wayland client, wlfreerdp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Val Packett <val> | ||||||||
Component: | Individual Port(s) | Assignee: | Carlos J. Puga Medina <cpm> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | cpm, kevans, xxjack12xx | ||||||||
Priority: | --- | Flags: | kevans:
maintainer-feedback+
|
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 224658 | ||||||||||
Attachments: |
|
Looks good to me; how well do these patches apply against a more recent FreeRDP? I'll admit that I've not been following FreeRDP development as much since my laptop recently died and I'm working on replacing it with a Pinebook. I do see that they've released a second rc for 2.0.0, though, so hopefully an actual release can be near. (In reply to Kyle Evans from comment #1) Tried rc1. These patches apply fine. LibreSSL patches need to be removed as they merged them: https://github.com/FreeRDP/FreeRDP/pull/4061 But they've added FIPS mode without checking for LibreSSL there :D Sent a fix: https://github.com/FreeRDP/FreeRDP/pull/4298 Also, wlfreerdp needs to be run with '-clipboard': https://github.com/FreeRDP/FreeRDP/issues/3414 Created attachment 189199 [details]
freerdp-wayland.patch
- Add multimedia/v4l_compat dependency for missing linux/input.h
- Fix pkg-plist
Created attachment 189201 [details]
freerdp-wayland.diff
- Sort OPTIONS_DEFAULT, OPTIONS_DEFINE, GSTREAMER_USE, WAYLAND_LIB_DEPENDS and X11_USE
- Sort option helpers
@Greg You have enabled WAYLAND option by default, is the change intentional or not? (In reply to Carlos J. Puga Medina from comment #5) Yeah, I think it should be on by default everywhere (see recent discussion on freebsd-x11, tl;dr please don't make wayland users recompile everything from ports :D) (In reply to Greg V from comment #6) FWIW- unless the ports tree/framework has an official policy on this, I'm OK with it being default here. The overhead is not enough to be argued over by non-Wayland folks and it's separate from X bits so not much chance in breaking things for them either. A commit references this bug: Author: cpm Date: Mon Jan 1 19:57:37 UTC 2018 New revision: 457792 URL: https://svnweb.freebsd.org/changeset/ports/457792 Log: net/freerdp: enable Wayland client, wlfreerdp - Add WAYLAND support option and enabled it by default - Sort options helpers - Bump PORTREVISION PR: 223913 Submitted by: Greg V <greg@unrelenting.technology> Reviewed by: cpm, kevans Approved by: kevans (maintainer) Changes: head/net/freerdp/Makefile head/net/freerdp/files/patch-uwac_libuwac_CMakeLists.txt head/net/freerdp/files/patch-uwac_libuwac_uwac-os.c head/net/freerdp/pkg-plist Committed, thanks! Getting this with the wayland knob enabled. ===> Applying FreeBSD patch patch-libfreerdp_crypto_crypto.c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- libfreerdp/crypto/crypto.c.orig 2017-08-05 09:35:32 UTC |+++ libfreerdp/crypto/crypto.c -------------------------- Patching file libfreerdp/crypto/crypto.c using Plan A... Hunk #1 failed at 388. 1 out of 1 hunks failed--saving rejects to libfreerdp/crypto/crypto.c.rej done => FreeBSD patch patch-libfreerdp_crypto_crypto.c failed to apply cleanly. => Patch(es) patch-CMakeLists.txt patch-client_Wayland_CMakeLists.txt patch-client_X11_CMakeLists.txt patch-cmake_FindGStreamer__1__0.cmake patch-ffmpeg29 applied cleanly. *** Error code 1 (In reply to xxjack12xx from comment #10) @cpm: Ah, files/patch-libfreerdp_crypto_crypto.c needs to go away. Please either go ahead and `svn rm` it, or give me approval and I'll do it. =) (In reply to Kyle Evans from comment #11) Fixed in r458085 |
Created attachment 188321 [details] freerdp-wayland.patch This patch adds a WAYLAND option to FreeRDP. Tested with wlroots' rootston compositor.