Bug 223957

Summary:	man page for pf.conf references pflow(4) which doesn't exist.
Product:	Documentation	Reporter:	Tim Chase <freebsd>
Component:	Manual Pages	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	0mp, allanjude, doc, kp
Priority:	---	Keywords:	needs-patch
Version:	Latest
Hardware:	Any
OS:	Any

Description Tim Chase 2017-11-29 01:43:56 UTC

The manpage for `pf.conf(5)` references a "pflow(4) interface" both within the document and in the SEE ALSO section.  However, there is no `pflow(4)` manpage and `apropos pflow` returns nothing.  Asking on IRC turned up https://lists.freebsd.org/pipermail/freebsd-pf/2014-July/007409.html which references the port `net/pfflow` but there's no way I would have found that based on current docs within a fresh/stock base system.

Is there something that can be done to make this clear in the docs?  Perhaps reference `net/pfflow` in conjunction with the introduction to pflow?

Comment 1 fsr22 2018-11-11 14:12:09 UTC

You also find pflow mentioned in ObsoleteFiles.inc,

  # 20120908: pf cleanup
  OLD_FILES+=usr/include/net/if_pflow.h

and sys/net/pfvar.h,

  /*  was	PFSTATE_PFLOW		0x04 */

I don't think the net/pflowd port is relevant, it is also marked as broken.

Comment 2 commit-hook freebsd_committer

2019-01-05 05:50:21 UTC

A commit references this bug:

Author: kp
Date: Sat Jan  5 05:50:16 UTC 2019
New revision: 342784
URL: https://svnweb.freebsd.org/changeset/base/342784

Log:
  pf: Remove references to pflow from the pf.conf man page

  pflow no longer exists. It was removed as part of a pf update back in 2012
  (r240233).

  PR:		223957
  MFC after:	1 week

Changes:
  head/share/man/man5/pf.conf.5

Comment 3 commit-hook freebsd_committer

2019-01-12 05:39:31 UTC

A commit references this bug:

Author: kp
Date: Sat Jan 12 05:38:48 UTC 2019
New revision: 342955
URL: https://svnweb.freebsd.org/changeset/base/342955

Log:
  MFC r342784:

  pf: Remove references to pflow from the pf.conf man page

  pflow no longer exists. It was removed as part of a pf update back in 2012
  (r240233).

  PR:		223957

Changes:
_U  stable/12/
  stable/12/share/man/man5/pf.conf.5

Comment 4 commit-hook freebsd_committer

2019-01-12 05:44:38 UTC

A commit references this bug:

Author: kp
Date: Sat Jan 12 05:44:10 UTC 2019
New revision: 342956
URL: https://svnweb.freebsd.org/changeset/base/342956

Log:
  MFC r342784:

  pf: Remove references to pflow from the pf.conf man page

  pflow no longer exists. It was removed as part of a pf update back in 2012
  (r240233).

  PR:		223957

Changes:
_U  stable/11/
  stable/11/share/man/man5/pf.conf.5