Bug 223966
| Summary: | archivers/brotli: Update to 1.0.2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||||
| Component: | Individual Port(s) | Assignee: | Bernard Spil <brnrd> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | freebsd, osa | ||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(osa) |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 223967 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 188409 [details]
svn diff for archivers/brotli
Ran into a nasty bug with ports framework here. brotli built with cmake, curl has brotli support, circular dependency.
Updated the port to stop using cmake and switch to automake. This involved some hacking as it requires you to run bootstrap which uses arithmetic not available in real sh. Additionally this lead to shared libs not linking to libbrotlicommon.so killing linking in curl (already during configure).
Currently building all ports in poudriere. Both Apache and cURL with brotli support.
The Makefile.am patch is already merged upstream https://github.com/google/brotli/pull/623 Hi Bernard, I'll take a look on it soon. We also need to update www/nginx and www/nginx-devel as well, both are using a archivers/brotli for third-party module ngx_brotli. (In reply to Sergey A. Osokin from comment #3) Hi Sergey, I've updated the brotli module for nginx to a version that supports more recent brotli ABI, see bug #224000. Comment on attachment 188409 [details]
svn diff for archivers/brotli
Hi Bernard,
I'd recommend to update the patch with a small change for shared libraries to expose PORTVERSION for PLIST_SUB and utilize it in pkg-plist.
Created attachment 188682 [details]
svn diff for archivers/brotli
Updated as per maintainer request. Uses PORTVERSION as SHLIBVER in pkg-plist.
Looks great! Hope it doesn't break anything in ports tree. Please go ahead and commit the change, it's approved now. Thanks. A commit references this bug: Author: brnrd Date: Tue Dec 12 08:11:26 UTC 2017 New revision: 456110 URL: https://svnweb.freebsd.org/changeset/ports/456110 Log: archivers/brotli: Update to 1.0.2 PR: 223966 Approved by: osa (maintainer) Changes: head/archivers/brotli/Makefile head/archivers/brotli/distinfo head/archivers/brotli/files/ head/archivers/brotli/files/patch-freebsd-upstream head/archivers/brotli/pkg-plist YW! |
Created attachment 188392 [details] svn diff for archivers/brotli ``` archivers/brotli: Update to 1.0.2 PR: ``` Also renames bro to brotli. Might warrant an UPDATING entry?