Bug 223988
| Summary: | devel/qt4-dbus: mark broken on aarch64 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | adridg | ||||||
| Priority: | --- | Flags: | rakuco:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://reviews.freebsd.org/D13935 | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219112 | ||||||||
| Attachments: |
|
||||||||
Created attachment 189334 [details]
Patch out constness
Probably the port should be marked broken on aarch64 -- there does not seem to be any native atomic operations for the architecture (there is armv7, but forcing that implementation of atomics yields lots of inline-assembly errors). The qglobal.h on aarch64 #defines Q_ARCH_GENERIC, so it's not being detected properly elsewhere.
Since Qt4 was end-of-lifed around 2012, with extended-extended-enterprise support lasting through 2015, I can imagine there was not much 64-bit ARM support back then.
The newly attached patch, though, gets devel/qt4-dbus to compile .. I can imagine adding that to extrapatches for aarch64 as it seems a bit of a hack anyway.
Fedora does have https://src.fedoraproject.org/rpms/qt/blob/master/f/qt-aarch64.patch, I just wonder if it makes sense to commit to supporting it in the ports tree. A commit references this bug: Author: adridg Date: Fri Jan 19 22:35:15 UTC 2018 New revision: 459478 URL: https://svnweb.freebsd.org/changeset/ports/459478 Log: Fix Qt4 atomics on aarch64. Add a patch from Fedora (similar changes in Arch and Debian) that implements the atomics; removes the use of generic atomics on aarch64. This allows textproc/qt4-dbus to build. PR: 223988 Reported by: linimon Approved by: tcberner (mentor) Obtained from: Fedora (url is in patch) Differential Revision: https://reviews.freebsd.org/D13935 Changes: head/Mk/bsd.qt.mk head/devel/qt4/files/extrapatch-aarch64 head/devel/qt4-corelib/Makefile head/devel/qt4-corelib/pkg-plist |
Created attachment 188420 [details] patch to mark port broken This port still fails to build on aarch64 as of 2017-02-18 19:48:05Z.