Bug 224036

Summary:	reviews.freebsd.org does not exclude reviews after commit
Product:	Services	Reporter:	Jochen Neumeister <joneum>
Component:	Code Review	Assignee:	Phabric Admin <phabric-admin>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	allanjude, joneum, pi
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any

Description Jochen Neumeister freebsd_committer

2017-12-02 12:07:24 UTC

Some reviews I have to close by hand in the last few days. It does not work automatically:


https://reviews.freebsd.org/D13323

Commit Log: https://svnweb.freebsd.org/changeset/ports/455317

Differential Revision:	https://reviews.freebsd.org/D13323


##########


https://reviews.freebsd.org/D13343

Commit Log: https://svnweb.freebsd.org/changeset/ports/455348

Differential Revision:	https://reviews.freebsd.org/D13343

Comment 1 Kurt Jaeger freebsd_committer

2018-03-09 17:08:50 UTC

Is the problem solved ? There was a new phabric version recently rolled out.
If possible, test with one of the next reviews if the problem is still open ?

Comment 2 Jochen Neumeister freebsd_committer

2018-03-11 20:48:27 UTC

(In reply to Kurt Jaeger from comment #1)

Heya Pi,

It's been a while since I opened a review. I'll open a new review for a commit and give it a try to test it.

Comment 3 Allan Jude freebsd_committer

2018-03-13 18:10:08 UTC

Note: A review is only auto-closed if it is in an 'accepted' stage.

Comment 4 Jochen Neumeister freebsd_committer

2018-03-13 18:17:06 UTC

(In reply to Allan Jude from comment #3)

As you can see, both reviews are approved by Mentor ;-)

Comment 5 Jochen Neumeister freebsd_committer

2018-07-25 05:14:41 UTC

i close here. It works. I could not reproduce the mistake anymore