Bug 224088

Summary: comms/usrp: fails to build with boost 1.66
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: hamradio (Nobody) <hamradio>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: rene, w.schwarzenfeld
Priority: --- Keywords: needs-patch
Version: LatestFlags: bugzilla: maintainer-feedback? (hamradio)
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224087
Bug Depends on:    
Bug Blocks: 223922    
Description Flags
svn-diff-usrp-boost_1_66_v3 none

Description Jan Beich freebsd_committer 2017-12-04 17:44:32 UTC
As part of exp-run in bug 223922 this port was found to break on Boost update. If the issue won't disappear on its own by Boost release I plan to mark the port as BROKEN. Can you check with upstream maintainer or help with a fix?

$ fetch -qo- 'https://reviews.freebsd.org/D13279?download=true' | patch -Efsp0 -d /usr/ports
$ make all deinstall install clean -C/usr/ports/devel/boost-libs
$ make -C/usr/ports/comms/usrp
host/lib/transport/udp_zero_copy.cpp:193:29: error: no member named 'native' in 'boost::asio::basic_datagram_socket<boost::asio::ip::udp>'
        _sock_fd = _socket->native();
                   ~~~~~~~  ^

Comment 1 Jan Beich freebsd_committer 2017-12-04 17:46:58 UTC
I forgot to adjust error message from comm/uhd. However, comms/usrp is only slightly different:

host/lib/transport/udp_zero_copy.cpp:166:29: error: no member named 'native' in 'boost::asio::basic_datagram_socket<boost::asio::ip::udp>'
        _sock_fd = _socket->native();
                   ~~~~~~~  ^
Comment 2 Jan Beich freebsd_committer 2018-02-14 05:45:02 UTC
This port was marked BROKEN in ports r459315. Do you plan to apply a fix similar to ports r459615?
Comment 3 Walter Schwarzenfeld freebsd_triage 2018-02-14 11:26:44 UTC
Created attachment 190608 [details]

Based on this patch 

Added and changed some things. Added LIB_DEPENDS to Makefile.
Should work (in the moment only test with the port).
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-02-14 11:31:19 UTC
Created attachment 190609 [details]

First was wrong svn-diff.
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-02-14 13:02:28 UTC
Created attachment 190613 [details]

Forgot remove broken.
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-02-14 13:10:30 UTC
Created attachment 190614 [details]

svn ...
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-02-14 16:52:25 UTC
Poudriere tests with 10.4amd64 and 11.1amd64 ok.
Comment 8 Jan Beich freebsd_committer 2018-07-17 09:20:37 UTC
portmgr@ set EXPIRATION_DATE in ports r474787. Do you plan to fix or update the port?
Comment 9 Rene Ladan freebsd_committer 2018-08-21 18:32:07 UTC
Maintainer timeout and patch is no longer valid, removing port.