Bug 224187

Summary:

net-p2p/zetacoin: fails to build with boost 1.66

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

Jan Beich <jbeich>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

daniel

Priority:

---

Keywords:

needs-patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (daniel)

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

223922

Attachments:

Description	Flags
patch for bitcoin-cli.cpp	none
patch for rpcserver.cpp	none

Description Jan Beich freebsd_committer

2017-12-08 16:15:54 UTC

As part of exp-run in bug 223922 this port was found to break on Boost update. If the issue won't disappear on its own by Boost release I plan to mark the port as BROKEN. Can you check with upstream maintainer or help with a fix?

$ fetch -qo- 'https://reviews.freebsd.org/D13279?download=true' | patch -Efsp0 -d /usr/ports
$ make all deinstall install clean -C/usr/ports/devel/boost-libs
$ make -C/usr/ports/net-p2p/zetacoin
[...]
bitcoin-cli.cpp:108:31: error: no matching constructor for initialization of 'boost::asio::ssl::context'
    boost::asio::ssl::context context(io_service, boost::asio::ssl::context::sslv23);
                              ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/boost/asio/ssl/impl/context.ipp:63:10: note: candidate constructor not viable: requires single argument 'm', but 2 arguments were provided
context::context(context::method m)
         ^
/usr/local/include/boost/asio/ssl/context.hpp:36:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class context
      ^

http://package23.nyi.freebsd.org/data/103i386-default-PR223922/2017-12-02_11h06m37s/logs/errors/zetacoin-0.11.2.3_12.log
http://package22.nyi.freebsd.org/data/103amd64-default-PR223922/2017-12-02_11h06m39s/logs/errors/zetacoin-0.11.2.3_12.log
http://package23.nyi.freebsd.org/data/111i386-default-PR223922/2017-12-03_09h31m14s/logs/errors/zetacoin-0.11.2.3_12.log
http://package22.nyi.freebsd.org/data/111amd64-default-PR223922/2017-12-03_09h31m05s/logs/errors/zetacoin-0.11.2.3_12.log

http://package23.nyi.freebsd.org/data/103i386-default-PR223922/2017-12-02_11h06m37s/logs/errors/zetacoin-nox11-0.11.2.3_12.log
http://package22.nyi.freebsd.org/data/103amd64-default-PR223922/2017-12-02_11h06m39s/logs/errors/zetacoin-nox11-0.11.2.3_12.log
http://package23.nyi.freebsd.org/data/111i386-default-PR223922/2017-12-03_09h31m14s/logs/errors/zetacoin-nox11-0.11.2.3_12.log
http://package22.nyi.freebsd.org/data/111amd64-default-PR223922/2017-12-03_09h31m05s/logs/errors/zetacoin-nox11-0.11.2.3_12.log

Comment 1 Jan Beich freebsd_committer

2017-12-08 16:16:18 UTC

Maybe you can replace io_service with io_context similar to https://github.com/arvidn/libtorrent/commit/f42b63c7ea82

Comment 2 Daniel Morante 2017-12-08 22:50:53 UTC

I don't know how to test with boost 1.66.  Grabbing the latest ports tree with portsnap still gives me 1.65.

Anyway, does the problem still occur if you try it with this version?: https://github.com/tuaris/FreeBSD-Coin-Ports/tree/master/ports/zetacoin

Comment 3 Daniel Morante 2017-12-08 22:52:27 UTC

Sorry, I just re-read your initial comment.  I'll try that.

Comment 4 Daniel Morante 2017-12-09 02:14:06 UTC

I've filed the issue with the upstream project.  The suggestion to io_context in place of io_service didn't work or the changes required are above my understanding of C++ code.

https://github.com/zetacoin/zetacoin/issues/12

Comment 5 Daniel Morante 2018-01-13 05:07:44 UTC

Created attachment 189677 [details]
patch for bitcoin-cli.cpp

Comment 6 Daniel Morante 2018-01-13 05:08:18 UTC

Created attachment 189678 [details]
patch for rpcserver.cpp

Comment 7 Daniel Morante 2018-01-13 05:08:42 UTC

These patches will allow the build to succeed.  They will be included in the next port update to 0.11.3.4

Comment 8 commit-hook freebsd_committer

2018-01-18 04:01:52 UTC

A commit references this bug:

Author: jbeich
Date: Thu Jan 18 04:01:01 UTC 2018
New revision: 459313
URL: https://svnweb.freebsd.org/changeset/ports/459313

Log:
  net-p2p/zetacoin: unbreak with boost 1.66

  PR:		224187
  Submitted by:	Daniel Morante (maintainer)

Changes:
  head/net-p2p/zetacoin/Makefile
  head/net-p2p/zetacoin/files/patch-src_bitcoin-cli.cpp
  head/net-p2p/zetacoin/files/patch-src_rpcserver.cpp

Comment 9 Jan Beich freebsd_committer

2018-01-18 04:18:24 UTC

Thanks. Landed.