Bug 224254

Summary: shells/fish: Does not build for armv6 since upgrade to 2.7
Product: Ports & Packages Reporter: Marcel Bischoff <marcel>
Component: Individual Port(s)Assignee: Mark Linimon <linimon>
Status: Closed FIXED    
Severity: Affects Only Me CC: asomers, freebsd-arm, linimon
Priority: --- Flags: bugzilla: maintainer-feedback? (asomers)
Version: Latest   
Hardware: arm   
OS: Any   
Attachments:
Description Flags
Poudriere build log
none
Fix the build on arm and arm64 none

Description Marcel Bischoff 2017-12-11 21:15:54 UTC
Created attachment 188730 [details]
Poudriere build log

I'm using Poudriere on a 11.1 machine. Please see the attached log file.
Comment 1 Marcel Bischoff 2017-12-11 21:27:37 UTC
Have opened upstream issue: https://github.com/fish-shell/fish-shell/issues/4589
Comment 2 Alan Somers freebsd_committer freebsd_triage 2017-12-11 21:44:39 UTC
Looks like arm and arm64 alone define wchar_t as unsigned.  On other architectures, it's signed.  I don't have access to an arm machine, but I'll give you a patch that you can try.
Comment 3 Alan Somers freebsd_committer freebsd_triage 2017-12-11 21:56:18 UTC
Created attachment 188733 [details]
Fix the build on arm and arm64

Please try this patch.  I can't test it on arm myself, but it didn't break anything on amd64.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2017-12-12 02:41:38 UTC
I'll toss it into my upcoming run.
Comment 5 Alan Somers freebsd_committer freebsd_triage 2017-12-12 02:48:58 UTC
linimon, no need.  brd showed me how to build it with qemu.  I started a build before I left work.  I'll see in the morning whether it passed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-12-12 18:18:21 UTC
A commit references this bug:

Author: asomers
Date: Tue Dec 12 18:17:40 UTC 2017
New revision: 456179
URL: https://svnweb.freebsd.org/changeset/ports/456179

Log:
  shells/fish: fix 2.7.0 build for arm and arm64

  PR:		224254
  Reported by:	marcel@herrbischoff.com
  Sponsored by:	Spectra Logic Corp

Changes:
  head/shells/fish/files/
  head/shells/fish/files/patch-src_wgetopt.h
Comment 7 Marcel Bischoff 2017-12-12 20:12:12 UTC
Thanks, this patch appears to do the trick. I was able to successfully build and run it on an armv6 machine.

I believe this should be submitted upstream as you commented that it seems to be a architectural peculiarity.
Comment 8 Alan Somers freebsd_committer freebsd_triage 2017-12-12 23:26:22 UTC
Upstream pull request: https://github.com/fish-shell/fish-shell/pull/4593