Summary: | misc/py-tqdm should be using USE_PYTHON=concurrent | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Shane <FreeBSD> |
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | nc, pi |
Priority: | --- | Flags: | nc:
maintainer-feedback+
|
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Shane
2017-12-12 09:19:07 UTC
Also, the bug, if there is one, is in misc/py-tqdm that should be using USE_PYTHON=concurrent. (with the patch from bug 220214 to get the man page to not conflict) Summary changed per comment from mat@. The real issue is that repeating the same pkg install command can produce different results. py-tqdm is only one of many python ports that need updating to handle concurrent installs. It was a simple port with no deps that was only chosen as an example. Concurrent support is a different issue than the selection algorithm used by pkg. Flavours support for python is a first step that appears to also have plans on being used by other ports (like ruby) that may or may not support concurrent pkg installs. Improving the selection algorithm used by pkg can only prevent other issues in the future. A simple solution would be sorting found pkgs and installing the first, while a more advanced solution would consider DEFAULT_VERSIONS. I'm sure others would argue that in the initial example only one port should be installed, the one matching the set default version, which may or may not sort into first place. Looks good to me. Was committed with PR#226240 |