Bug 224319

Summary: deskutils/fet: update to 5.35.4, introduce FLAVORS
Product: Ports & Packages Reporter: Zsolt Udvari <uzsolt>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed Not Accepted    
Severity: Affects Some People CC: pi, portmgr, swills
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: uzsolt: maintainer-feedback+
pi: maintainer-feedback? (portmgr)
Hardware: Any   
OS: Any   
URL: https://lalescu.ro/liviu/fet/news.html
Attachments:
Description Flags
Patch.
uzsolt: maintainer-approval+
Patch to 5.34.3
uzsolt: maintainer-approval+
5.34.3 (remove default EXAMPLES option)
uzsolt: maintainer-approval+
Patch to 5.35.0
uzsolt: maintainer-approval+
Patch to 5.35.1
none
update to 5.35.3
uzsolt: maintainer-approval+
update to 5.35.4 uzsolt: maintainer-approval+

Description Zsolt Udvari 2017-12-13 07:49:00 UTC
Update to 5.34.2
Introduce flavor so will build fet (with gui), fet-cli (only commandline version) and fet-examples (the provided example files).

Changelog (https://lalescu.ro/liviu/fet/news.html):
- updated to Qt 5.10.0
Comment 1 Zsolt Udvari 2017-12-13 08:12:39 UTC
Created attachment 188800 [details]
Patch.
Comment 2 Steve Wills freebsd_committer 2017-12-14 15:35:19 UTC
Hi,

Examples shouldn't be a flavor. Can you revise the patch and resubmit?

Thanks!
Comment 3 Zsolt Udvari 2017-12-14 18:50:42 UTC
(In reply to Steve Wills from comment #2)
Yes of course, maybe tomorrow.
Comment 4 Zsolt Udvari 2017-12-26 09:44:32 UTC
Created attachment 189107 [details]
Patch to 5.34.3

Update to 5.34.3
Remove examples flavor.
Comment 5 Zsolt Udvari 2017-12-26 09:49:32 UTC
Created attachment 189108 [details]
5.34.3 (remove default EXAMPLES option)

It was my bug to add EXAMPLES to OPTIONS_DEFAULT.
Comment 6 Zsolt Udvari 2018-01-11 15:59:39 UTC
Created attachment 189619 [details]
Patch to 5.35.0

Updated patch, FET version 5.35.0.
News: https://lalescu.ro/liviu/fet/news.html
Comment 7 Zsolt Udvari 2018-01-18 18:35:43 UTC
Created attachment 189890 [details]
Patch to 5.35.1

Patch to 5.35.1.
Changelog: https://lalescu.ro/liviu/fet/news.html
Comment 8 Zsolt Udvari 2018-03-09 04:19:01 UTC
Created attachment 191329 [details]
update to 5.35.3
Comment 9 Zsolt Udvari 2018-03-22 04:46:01 UTC
Created attachment 191727 [details]
update to 5.35.4

Portlint OK.
Poudriere tests are OK on 10amd64 and 11amd64 with gui and cli flavors too.
Comment 10 Kurt Jaeger freebsd_committer 2018-04-07 17:59:14 UTC
testbuild@work
Comment 11 Kurt Jaeger freebsd_committer 2018-04-07 18:42:07 UTC
Commits for new flavor-types need portmgr-approval. It's unclear to me if this cli/gui versioning shouldn't better be done using options instead of flavors.
Comment 12 Zsolt Udvari 2018-04-08 09:24:30 UTC
(In reply to Kurt Jaeger from comment #11)
I think the gui-cli split is useful (at least for me :) ).
I use fet once a year for about a month (I'm a teacher and I used to create the my school's timetable) and my workflow is:
- create the fet-file (which stores the datas: list of teacher, students, rooms, activities, etc.) using Qt-gui (it's easier than editing XML-files manually)
- upload the fet-file to a server (VPS) and the server (hopefully) will generates the timetable

The GUI on server is unnecessary but on my desktop the GUI is essential. So I would install fet-gui on desktop and fet-cli on server (and wouldn't need to install it from ports). This split is similar to editors/vim (GTK2) and editors/vim-console (without any GUI).
As the Porter's Handbook writes: "a port can have a normal version with many features and quite a few dependencies, and a light “lite” version with only basic features and minimal dependencies" and "If a port has a “lite” slave port, the slave port can be removed, and the port can be converted to flavors with...".
Comment 13 Mathieu Arnold freebsd_committer 2018-06-20 11:23:11 UTC
The package does not have to be built differently to get both cli and gui, it just builds them, or not.

So, this is not flavors, this is subpackages, which is a feature we do not have yet, and for which flavors will not be used.
Comment 14 Mathieu Arnold freebsd_committer 2018-06-20 11:24:14 UTC
To give you an example of possible flavors, it would be, for this port, qt4/qt5, you cannot build both at the same time, you have to choose one of the other.