Bug 224475
| Summary: | [MAINTAINER] graphics/gimmage: fix, and update to c++11 (removes BROKEN) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | Keywords: | easy, patch, patch-ready | ||||||||
| Priority: | --- | Flags: | portmaster:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 188986 [details]
svn diff for graphics/gimmage v2 (obsoletes previous)
Oops! forgot the additional patch added for
this PORTREVISION.
Created attachment 189000 [details]
svn diff for graphics/gimmage v3 (obsoletes previous)
This (final) snv diff simply pets portlint
(the NLS warning/suggestion)
That's it!
Thanks!
A commit references this bug: Author: swills Date: Sun Dec 24 18:55:45 UTC 2017 New revision: 457192 URL: https://svnweb.freebsd.org/changeset/ports/457192 Log: graphics/gimmage: fix, and update to c++11 PR: 224475 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> (maintainer) Changes: head/graphics/gimmage/Makefile head/graphics/gimmage/files/patch-src__FileManager.cpp head/graphics/gimmage/files/patch-src__ImageEventBox.cpp Committed, thanks! |
Created attachment 188985 [details] svn diff for graphics/gimmage OK this port has been listed as BROKEN The svn diff attached to this pr(1) corrects that by bringing it closer to c++11 Tested on: FreeBSD dev-box 12.0-CURRENT FreeBSD 12.0-CURRENT #0: Wed Dec 13 06:07:59 PST 2017 root@dev-box:/usr/obj/usr/src/amd64.amd64/sys/DEVBOX (r326065) with the following results: Script started on Tue Dec 19 21:03:24 2017 dev-box# make -DBATCH check-plist ... install -m 0644 'gimmage.desktop' '/usr/ports/graphics/gimmage/work/stage/usr/local/share/applications/gimmage.desktop' ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) dev-box# make stage-qa ====> Running Q/A tests (stage-qa) dev-box# make check-sanity ===> License GPLv2+ accepted by the user dev-box# portlint WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. WARN: /usr/ports/graphics/gimmage/files/patch-src__FileManager.cpp: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /usr/ports/graphics/gimmage/files/patch-src__ImageEventBox.cpp: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. 0 fatal errors and 3 warnings found. dev-box# exit Script done on Tue Dec 19 21:25:38 2017 Thanks! --Chris