Bug 224481

Summary: Add H3 to aw_sid driver for Allwinner SoC
Product: Base System Reporter: Eugene Sevastyanov <eval>
Component: armAssignee: freebsd-arm (Nobody) <freebsd-arm>
Status: Closed Not A Bug    
Severity: Affects Many People CC: kevans, manu
Priority: ---    
Version: CURRENT   
Hardware: arm   
OS: Any   
Attachments:
Description Flags
SID driver patch none

Description Eugene Sevastyanov 2017-12-20 13:28:40 UTC 
Created attachment 188991 [details]
SID driver patch

For the correct operation of the aw_thermal driver, a thermal calibration function is required, presented in the aw_sid driver. However, the driver does not support H3 SoC.
It is known that H3 SoC has a hardware bug when reading SID (root key) - see http://linux-sunxi.org/SID_Register_Guide#SID_PRCTL

I suggest a patch that more correctly implements the aw_sid driver.

DTS to enable the driver device:
...
sid: eeprom@1c14000 {
       compatible = "allwinner,sun8i-h3-sid";
       reg = <0x01c14000 0x400>;
};
...

The driver is tested on H2+ SoC (OrangePi Zero)
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2017-12-20 13:36:06 UTC 
Hello,

Thanks you for you patch, could you open a review on reviews.freebsd.org please ?

It's much easier to review code there.

Thanks.
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2017-12-20 14:05:29 UTC 
Patch moved to phabricator, closing this entry.

https://reviews.freebsd.org/D13556