Bug 224590

Summary: textproc/py-m2r: Upgrade to 0.1.12
Product: Ports & Packages Reporter: John W. O'Brien <john>
Component: Individual Port(s)Assignee: Jochen Neumeister <joneum>
Status: Closed FIXED    
Severity: Affects Some People CC: joneum
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
textproc/py-m2r: Upgrade to 0.1.12 john: maintainer-approval+

Description John W. O'Brien 2017-12-26 00:54:41 UTC
Created attachment 189102 [details]
textproc/py-m2r: Upgrade to 0.1.12

Changelog
=========

*   Upgrade to 0.1.12


QA
==

portlint: OK
poudriere: OK -- testport w/ py27 (default), py34, py35, py36
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-12-29 22:08:17 UTC
A commit references this bug:

Author: joneum
Date: Fri Dec 29 22:07:46 UTC 2017
New revision: 457545
URL: https://svnweb.freebsd.org/changeset/ports/457545

Log:
  textproc/py-m2r/Makefile: Update to 0.1.12

  PR:		224590
  Submitted by:	John W. O'Brien <john@saltant.com> (maintainer)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13683

Changes:
  head/textproc/py-m2r/Makefile
  head/textproc/py-m2r/distinfo
  head/textproc/py-m2r/files/
Comment 2 John W. O'Brien 2017-12-29 22:44:08 UTC
Hi joneum,

Thank you for committing this.

Insert previous rant (bug #223849, comment #7) here regarding the gratuitous change from PORTVERSION to DISTVERSION.

Also, what is the reason for the change to the timestamp in the distinfo? I can understand that you may wish to verify that the distinfo I submitted is valid since you are accountable for the commit. However, you can do that without changing the patch I submitted. Every change you make to my patch shows up as a conflict in my tree, which I then have to investigate and reconcile.
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2017-12-29 22:53:42 UTC
Hey John,

With such "small" changes, it is sometimes faster to do make makesum yourself, which can then lead to such changes.
Comment 4 John W. O'Brien 2017-12-29 23:06:25 UTC
(In reply to Jochen Neumeister from comment #3)

Your comment makes no sense to me. I hope I'm not being obtuse.

I provided an updated distinfo file in the patch. If there was something wrong with it, you should have brought it up with me so I could correct it. If there was nothing wrong with it you should have committed it without modification.
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2017-12-29 23:12:46 UTC
(In reply to John W. O'Brien from comment #4)

You want to discuss now because of another timestamp?