Bug 224613
| Summary: | Remove support for variables that have been deprecated for a while | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mathieu Arnold <mat> | ||||||||||||
| Component: | Ports Framework | Assignee: | Mathieu Arnold <mat> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | ports-bugs | ||||||||||||
| Priority: | --- | Flags: | antoine:
exp-run+
|
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| URL: | https://reviews.freebsd.org/D13490 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 189129 [details]
v2
Created attachment 189137 [details]
v3
Created attachment 189156 [details]
v4
Add some more stuff to the mix :-)
Exp-run results on 11.1 i386: http://package23.nyi.freebsd.org/build.html?mastername=111i386-default-PR224613&build=2018-01-02_19h53m22s New failures: + {"origin"=>"cad/calculix-ccx", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"databases/libdrizzle", "phase"=>"package", "errortype"=>"bad_C++_code"} + {"origin"=>"devel/cvsweb", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/cvsweb3", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/fpc-symbolic", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/motor", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"dns/dnsjava", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"games/scummvm-tools", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"graphics/povray37", "phase"=>"stage", "errortype"=>"???"} + {"origin"=>"graphics/xfig", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"lang/icon", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"multimedia/mlt", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"net/httpry", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"security/cyrus-sasl2-saslauthd", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch2", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch5", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/uim", "phase"=>"package", "errortype"=>"???"} Exp-run results on 10.3 amd64: http://package22.nyi.freebsd.org/build.html?mastername=103amd64-default-PR224613&build=2018-01-02_19h53m21s New failures: + {"origin"=>"cad/calculix-ccx", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"databases/libdrizzle", "phase"=>"package", "errortype"=>"bad_C++_code"} + {"origin"=>"devel/cvsweb", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/cvsweb3", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/fpc-symbolic", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"devel/motor", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"dns/dnsjava", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"games/scummvm-tools", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"graphics/povray37", "phase"=>"stage", "errortype"=>"???"} + {"origin"=>"graphics/xfig", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"lang/icon", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"multimedia/mlt", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"net/httpry", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"security/cyrus-sasl2-saslauthd", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch2", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/elasticsearch5", "phase"=>"package", "errortype"=>"???"} + {"origin"=>"textproc/uim", "phase"=>"package", "errortype"=>"???"} multimedia/mlt seems to be related to the addition of USES=eigen to graphics/movit no ? Yes, fixing movit. Created attachment 189401 [details]
v5
fix fallout.
Exp-run looks fine. A commit references this bug: Author: mat Date: Tue Jan 9 07:40:57 UTC 2018 New revision: 458513 URL: https://svnweb.freebsd.org/changeset/ports/458513 Log: Remove support for variables that have been deprecated for a while. variables deprecation revision WITHOUT_NLS 2013-12-13 r336337 WITH_/WITHOUT_ 2014-02-24 r345870 NOPORT(DOC|EXAMPLE)S 2014-04-19 r351587 WITH_BDB_VER 2016-05-02 r414444 OVERRIDE_LINUX_BASE_PORT 2016-09-05 r421387 WITH_OPENSSL_(BASE|PORT) 2016-06-16 r416965 While there, add an ERROR variable that works like DEV_ERROR, but for user facing errors, and move NOPORTDOCS, NOPORTEXAMPLES and WITHOUT_NLS to it. Cleanup bsd.sanity.mk a bit. Fix fallout. PR: 224613 Submitted by: mat Exp-run by: antoine Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D13490 Changes: head/Mk/Uses/bdb.mk head/Mk/Uses/cran.mk head/Mk/Uses/gem.mk head/Mk/bsd.default-versions.mk head/Mk/bsd.options.mk head/Mk/bsd.port.mk head/Mk/bsd.sanity.mk head/audio/chromaprint/Makefile head/audio/nas/Makefile.man head/audio/xmixer/Makefile head/audio/xoscope/Makefile head/cad/calculix-ccx/Makefile head/chinese/libtabe/Makefile head/chinese/p5-Lingua-ZH-TaBE/Makefile head/databases/libdrizzle/Makefile head/databases/libdrizzle/pkg-plist head/databases/ruby-bdb/Makefile head/devel/cvsweb/Makefile head/devel/cvsweb3/Makefile head/devel/motor/Makefile head/dns/dnsjava/Makefile head/games/scummvm-tools/Makefile head/graphics/mscgen/Makefile head/graphics/povray37/Makefile head/graphics/xfig/Makefile head/lang/fpc/Makefile head/lang/icon/Makefile head/mail/fastforward/Makefile head/net/httpry/Makefile head/net/p5-Net-Proxy/Makefile head/net/ssltunnel-client/Makefile head/net-mgmt/jnettop/Makefile head/news/golded+/Makefile head/news/leafnode/Makefile head/security/cyrus-sasl2/Makefile.common head/security/p5-SAVI-Perl/Makefile head/security/samhain/Makefile head/sysutils/grub2-pcbsd/Makefile head/sysutils/webjob/Makefile head/textproc/elasticsearch/Makefile head/textproc/elasticsearch2/Makefile head/textproc/elasticsearch5/Makefile head/textproc/par/Makefile head/textproc/uim/Makefile head/www/rubygem-passenger/Makefile head/x11-toolkits/tk86/Makefile.man |
Created attachment 189127 [details] v1 I don't expect any fallout, but to be safe.