Bug 224658
| Summary: | net/freerdp: Update to 2.0.0-rc1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Carlos J. Puga Medina <cpm> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Carlos J. Puga Medina <cpm> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | kevans, val | ||||||||||
| Priority: | --- | Flags: | kevans:
maintainer-feedback+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | 223913 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Carlos J. Puga Medina
2017-12-28 23:02:45 UTC
Created attachment 189195 [details]
patch-freerdp-2.0.0-rc1
- Add KERBEROS support
Hi cpm@, This looks mostly good to me; two things: 1.) Can I bug you to commit PR 223913 before-hand, so we end up with WAYLAND + 2.0.0-rc1? I note that that PR also introduces one more manpage that needs a %%MANPAGE%% option, but they seem to be generally orthogonal patches otherwise. 2.) Greg noted that FIPS in 2.0.0-rc1 needed a LibreSSL check, and submitted this PR: https://github.com/FreeRDP/FreeRDP/commit/22c71c0034a2ed61ff0052f842573d9398c8eec4 -- can you pull that patch in as well, please? I set maintainer-feedback+ anyways because I don't know that the LibreSSL patch is necessarily a blocker, but I would greatly appreciate it. (In reply to Kyle Evans from comment #2) I realized that a couple of patches need to be re-added to build FreeRDP with LibreSSL. I will fix the patch after commit bug 223913. Created attachment 189337 [details]
patch-freerdp-2.0.0-rc1
MANPAGES need xsltproc to be generated.
Greg, would you mind trying to build with LibreSSL? @Kyle We should properly set the CMAKE_INSTALL_MANDIR variable to fix these errors. % portlint -ac FATAL: /usr/ports/net/freerdp/pkg-plist: [233]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /usr/ports/net/freerdp/pkg-plist: [233]: Unpacked man file winpr-hash.1 listed. Must be gzipped. FATAL: /usr/ports/net/freerdp/pkg-plist: [234]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /usr/ports/net/freerdp/pkg-plist: [234]: Unpacked man file winpr-makecert.1 listed. Must be gzipped. FATAL: /usr/ports/net/freerdp/pkg-plist: [235]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /usr/ports/net/freerdp/pkg-plist: [235]: Unpacked man file wlfreerdp.1 listed. Must be gzipped. FATAL: /usr/ports/net/freerdp/pkg-plist: [236]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /usr/ports/net/freerdp/pkg-plist: [236]: Unpacked man file xfreerdp.1 listed. Must be gzipped. FATAL: /usr/ports/net/freerdp/pkg-plist: [237]: Man pages must be installed into ``man'' not ``share/man''. FATAL: /usr/ports/net/freerdp/pkg-plist: [237]: Unpacked man file wlog.7 listed. Must be gzipped. WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. WARN: Makefile: "BROKEN" has to appear earlier. 10 fatal errors and 2 warnings found. Created attachment 189352 [details]
patch-freerdp-2.0.0-rc1
Fix install MANPAGES to /usr/local/man.
Manpages installed to the wrong place. The correct location, per hier(7), is /usr/local/man
Comment on attachment 189352 [details]
patch-freerdp-2.0.0-rc1
+1 on the man change; I hadn't caught that previously. Greg's previous comment on LibreSSL seemed to indicate that fips was the only problem he encountered with 2.0.0 when he tested, so I think it's safe to assume this is good to go.
A commit references this bug: Author: cpm Date: Thu Jan 4 19:37:59 UTC 2018 New revision: 458051 URL: https://svnweb.freebsd.org/changeset/ports/458051 Log: net/freerdp: Update to 2.0.0-rc1 - Enable 64 bit file support in winpr - Remove unneeded patches (added upstream) - Add support for ICU for unicode conversion - Add support for KERBEROS - Add MANPAGES option and fix man pages installation in /usr/local/man - Fix WWW in pkg-descr - Pet portlint Changelog: https://github.com/FreeRDP/FreeRDP/blob/2.0.0-rc1/ChangeLog PR: 224658 Submitted by: cpm Reviewed by: kevans Approved by: kevans (maintainer) Changes: head/net/freerdp/Makefile head/net/freerdp/distinfo head/net/freerdp/files/patch-client_Wayland_CMakeLists.txt head/net/freerdp/files/patch-client_X11_CMakeLists.txt head/net/freerdp/files/patch-winpr_CMakeLists.txt head/net/freerdp/files/patch-winpr_libwinpr_crypto_hash.c head/net/freerdp/files/patch-winpr_libwinpr_utils_ssl.c head/net/freerdp/files/patch-winpr_tools_hash-cli_CMakeLists.txt head/net/freerdp/files/patch-winpr_tools_makecert-cli_CMakeLists.txt head/net/freerdp/files/patch-winpr_tools_makecert_makecert.c head/net/freerdp/pkg-descr head/net/freerdp/pkg-plist Committed, thanks! A commit references this bug: Author: cpm Date: Thu Jan 4 20:40:52 UTC 2018 New revision: 458085 URL: https://svnweb.freebsd.org/changeset/ports/458085 Log: Remove leftover patch PR: 224658 Reported by: xxjack12xx@gmail.com Approved by: kevans (maintainer) Changes: head/net/freerdp/files/patch-libfreerdp_crypto_crypto.c |