Bug 224672

Summary: sysutils/password-store extensions not getting loaded at runtime
Product: Ports & Packages Reporter: Adam Jimerson <vendion>
Component: Individual Port(s)Assignee: Rene Ladan <rene>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (rene)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Adam Jimerson 2017-12-29 13:27:27 UTC 
The password-store 1.7.1_1 installed through pkg does not not seem to search for extensions under /usr/local/lib/password-store/extensions instead it seems it may still be looking for them under the default /usr/lib/password-store/extensions directory (I only skimmed through the Makefile so I may have missed where it corrects this, and didn't see a patch for it).

Steps to reproduce:
1. Install one or more extension(s) for password-store with /usr/local PREFIX (list of extensions can be found here https://www.passwordstore.org/)
2. Try to use the installed extension: pass otp Shopping/www.amazon.com/(email redacted)

Expected results:
In my above example of using the pass-otp extension I would expect a valid one time password for my Amazon login to be returned.

Actual results:
Pass returns the following error: "Error: otp is not in the password store." which seems to imply that it tried to find a otp.gpg file within the password store directory.

In my case I have two extensions installed
[vendion@Heimdall][~]% ls /usr/local/lib/password-store/extensions
otp.bash*	update.bash*

I have not tested the pass-update extension as I have no need to update a password currently but I expect the same results.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-06 17:41:40 UTC 
A commit references this bug:

Author: rene
Date: Sat Jan  6 17:41:32 UTC 2018
New revision: 458281
URL: https://svnweb.freebsd.org/changeset/ports/458281

Log:
  Make system extensions work with password-store.

  System extensions are installed in PREFIX/lib/password-store/extensions/

  Bump PORTREVISION

  PR:		224672
  Submitted by:	Adam Jimerson (vendion@gmail.com)
  MFH:		2018Q1

Changes:
  head/sysutils/password-store/Makefile
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2018-01-06 17:42:37 UTC 
Fixed in 1.7.1_2, thanks for the report.
Comment 3 Adam Jimerson 2019-03-27 22:56:24 UTC 
It seems as though this issue has been regressed with version 1.7.3_1 as it's not able to find installed extensions like pass-otp again.
Comment 4 Adam Jimerson 2019-03-27 23:02:47 UTC 
(In reply to Adam Jimerson from comment #3)

Okay sorry for the spam, I just saw this change in the ports tree https://svnweb.freebsd.org/ports/head/sysutils/password-store/files/pass.in?revision=491655&view=markup that changes the directory that pass will check for extensions from %%PREFIX%%/lib to %%PREFIX%%/libexec but there was no note able it in the UPDATING file.

Should there have been an entry there to notify users of this change, rather than silently breaking it and leaving it to users to figure out after the fact?
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-04-10 13:13:41 UTC 
A commit references this bug:

Author: rene
Date: Wed Apr 10 13:13:21 UTC 2019
New revision: 498562
URL: https://svnweb.freebsd.org/changeset/ports/498562

Log:
  Belatedly add an entry to UPDATING for sysutils/password-store

  PR:		224672
  Reported by:	Adam Jimerson vendion@gmail.com

Changes:
  head/UPDATING
Comment 6 Rene Ladan freebsd_committer freebsd_triage 2019-04-10 13:15:46 UTC 
I added an entry to UPDATING, thanks for the suggestion.