Bug 224834

Summary: net/samba46 fails to build with base gcc
Product: Ports & Packages Reporter: Justin Hibbits <jhibbits>
Component: Individual Port(s)Assignee: Timur I. Bakeyev <timur>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: linimon
Priority: --- Flags: bugzilla: maintainer-feedback? (timur)
Version: Latest   
Hardware: Any   
OS: Any   

Description Justin Hibbits freebsd_committer 2018-01-02 03:20:22 UTC
When building net/samba46 on powerpc64 base gcc is used, which doesn't recognize the option "-Wno-format-truncation":

[ 594/3777] Compiling lib/replace/test/testsuite.c
runner cc -O2 -pipe -DLIBICONV_PLUG -D_FUNCTION_DEF -DLDAP_DEPRECATED -fno-strict-aliasing -Wno-format-zero-length -Wno-format-truncation -fPIC -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -fstack-protector -DSTATIC_replace_test_MODULES=NULL -DSTATIC_replace_test_MODULES_PROTO=extern void __replace_test_dummy_module_proto(void) -MD -Idefault/lib/replace -I../lib/replace -Idefault/include/public -I../include/public -Idefault/source4 -I../source4 -Idefault/lib -I../lib -Idefault/source4/lib -I../source4/lib -Idefault/source4/include -I../source4/include -Idefault/include -I../include -Idefault -I.. -I/usr/local/include -I/usr/local/include -DLIBICONV_PLUG -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1 -D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 ../lib/replace/test/testsuite.c -c -o default/lib/replace/test/testsuite_5.o
[ 595/3777] Compiling lib/replace/test/strptime.c
runner cc -O2 -pipe -DLIBICONV_PLUG -D_FUNCTION_DEF -DLDAP_DEPRECATED -fno-strict-aliasing -Wno-format-zero-length -Wno-format-truncation -fPIC -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -fstack-protector -DSTATIC_replace_test_MODULES=NULL -DSTATIC_replace_test_MODULES_PROTO=extern void __replace_test_dummy_module_proto(void) -MD -Idefault/lib/replace -I../lib/replace -Idefault/include/public -I../include/public -Idefault/source4 -I../source4 -Idefault/lib -I../lib -Idefault/source4/lib -I../source4/lib -Idefault/source4/include -I../source4/include -Idefault/include -I../include -Idefault -I.. -I/usr/local/include -I/usr/local/include -DLIBICONV_PLUG -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1 -D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 ../lib/replace/test/strptime.c -c -o default/lib/replace/test/strptime_5.o
cc1: error: unrecognized command line option "-Wno-format-truncation"
cc1: error: unrecognized command line option "-Wno-format-truncation"
Waf: Leaving directory `/wrkdirs/usr/ports/net/samba46/work/samba-4.6.12/bin'
Build failed:
 -> task failed (err #1):
        {task: cc testsuite.c -> testsuite_5.o}
 -> task failed (err #1):
        {task: cc strptime.c -> strptime_5.o}
Comment 1 Timur I. Bakeyev freebsd_committer 2018-01-02 04:09:22 UTC
Can you, please, try net/samba47 instead? Samba 4.6 is kind of hopeless on FreeBSD and not recommended.
Comment 2 Justin Hibbits freebsd_committer 2018-01-02 21:22:50 UTC
(In reply to Timur I. Bakeyev from comment #1)

I'll try that once my current poudriere build completes (later today or tomorrow).  I noticed this problem because the default samba was updated from 4.4 to 4.6, so if 4.7 is considered far superior to 4.6, will that soon become the default?
Comment 3 Justin Hibbits freebsd_committer 2018-01-03 15:31:10 UTC
I filed bug 224864 for net/samba47, which is just a trivial change to the port Makefile (it's building now, and got past the error here at this point).
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2018-12-06 14:36:48 UTC
This PR is a little stale by now.

Since it was filed, net/samba47 has been fixed on powerpc64.

I have a trivial patch to samba46 that fixes the build on powerpc64.  I'd like to know if I can either commit that, or if not, I would like to close this PR.  Thanks.
Comment 5 Timur I. Bakeyev freebsd_committer 2018-12-06 17:35:00 UTC
Mark, samba46 is obsoleted and should be wiped out of the ports. So, I guess, we'd close this PR.