Bug 224876
| Summary: | x11-toolkits/girara: missing dependencies | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Pawel Pekala <pawel> | ||||||
| Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | madpilot:
maintainer-feedback+
|
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
(In reply to Pawel Pekala from comment #0) > Created attachment 189376 [details] > add missing dependencies > > Girara has optional dependencies according to its README file, also > our stage-qa seems to confirm it: Thanks for reporting this! Unluckily poudriere builds are not exposing this. Unconditionally adding those as dependencies isn't necessarily the best option. My opinion is that while libnotify looks useful for all users, since it's needed for notification support, json-c could be left optional (forcing the port not to detect it, so no hidden dependencies are grown), since not all users are going to need it. I'm going to work out a patch with two options libinotify enabled by deafult and json-c disabled by default. Created attachment 189455 [details]
Patch adding options
I created a patch adding two options.
It works fine here and in poudriere testing.
Can you test it in your environment and check that it actually fixes the issue?
Thanks.
(In reply to Guido Falsi from comment #2) After changing variables names: JSON_MAKE_ENV -> JSON_MAKE_ENV_OFF NOTIFY_MAKE_ENV -> NOTIFY_MAKE_ENV_OFF patch works as expected for me. Thanks. A commit references this bug: Author: madpilot Date: Sat Jan 13 22:15:34 UTC 2018 New revision: 458944 URL: https://svnweb.freebsd.org/changeset/ports/458944 Log: - Add NOTIFY option, enabled by default - Add JSONC option, disabled by default These options allow controlling two optional dependencies of girara, which where being silently linked if present on the system when compiling. PR: 224876 Submitted by: pawel@ MFH: 2018Q1 Changes: head/x11-toolkits/girara/Makefile (In reply to Pawel Pekala from comment #3) > (In reply to Guido Falsi from comment #2) > After changing variables names: > > JSON_MAKE_ENV -> JSON_MAKE_ENV_OFF > NOTIFY_MAKE_ENV -> NOTIFY_MAKE_ENV_OFF > > patch works as expected for me. Thanks. Right, thanks for correcting this mistake. I committed the change. |
Created attachment 189376 [details] add missing dependencies Girara has optional dependencies according to its README file, also our stage-qa seems to confirm it: ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/libgirara-gtk3.so.3.0 is linked to /usr/local/lib/libnotify.so.4 from devel/libnotify but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libnotify.so:devel/libnotify Error: /usr/local/lib/libgirara-gtk3.so.3.0 is linked to /usr/local/lib/libjson-c.so.3 from devel/json-c but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libjson-c.so:devel/json-c This patch makes them default as they are IMHO not very heavy.