Bug 224903
| Summary: | [textproc/itstool] upgrade from 2.0.2 to 2.0.5 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michael Zhilin <mizhka> | ||||||||
| Component: | Individual Port(s) | Assignee: | Mikhail Teterin <mi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | dbaio, doc, freebsd-2024, lantw44, madpilot, mi, mizhka, ndowens04, rozhuk.im, tcberner, w.schwarzenfeld | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(kwm) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://github.com/itstool/itstool/issues/38 | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244325 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 232230 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Zhilin
2018-01-04 17:21:23 UTC
Patch doesn't apply cleanly, needs to be rebased Created attachment 196682 [details]
SVN patch
Updated patch.
Just some info, there are bugs in this release that break the build. One of these is a translation in the gnumeric package. So this needs to be tested before this update can be committed. Created attachment 200968 [details]
Upgrade to 2.0.5
Among the ChangeLog entries is the claim, that PY2/PY3 issues have been resolved. Indeed, I successfully built this port with Python-3.6 and then used it to successfully build gtk-doc.
A commit references this bug: Author: mi Date: Tue Mar 5 12:16:56 UTC 2019 New revision: 494694 URL: https://svnweb.freebsd.org/changeset/ports/494694 Log: Upgrade from 2.0.2 to 2.0.5. Among improvements is compatibility with Python-3 PR: 224903 Approved by: maintainer timeout Changes: head/textproc/itstool/Makefile head/textproc/itstool/distinfo This broke textproc/gtk-doc. (In reply to Tobias C. Berner from comment #6) Are you sure? Im buld today gtk-doc many times as dep for almost all ports that use it and no fail. (In reply to Tobias C. Berner from comment #6) Could you provide the build-log with the failure? I also experienced the breakage in poudriere. It was caused by the PKGNAMEPREFIX line removed in r494737. the error is: ===> gtk-doc-1.29 depends on executable: itstool - not found ===> gtk-doc-1.29 depends on package: /packages/All/py36-itstool-2.0.5.txz - not found ===> USE_PACKAGE_DEPENDS_ONLY set - not building missing dependency from source *** Error code 1 Stop. make: stopped in /usr/ports/textproc/gtk-doc (In reply to Guido Falsi from comment #9) Should fixed with ports r494737. Hi.
Another issue after this update is with FreeBSD translations.
There is a `make tran` command which do this:
@${ITSTOOL} -l ${PO_LANG} -m ${PO_LANG}.mo -o ${DOC}.xml ${DOC}.translate.xml
~/temp_zanata/doc_svn_https/pt_BR.ISO8859-1/articles/bsdl-gpl> make tran
~/temp_zanata/doc_svn_https/pt_BR.ISO8859-1/articles/bsdl-gpl> svn diff
Index: article.xml
===================================================================
--- article.xml (revision 52873)
+++ article.xml (working copy)
@@ -5,8 +5,8 @@
<info><title>Por que você deve usar uma licença de estilo BSD em seu Projeto Open Source</title>
<authorgroup>
- <author><personname><firstname>Bruce</firstname><surname>Montague</surname></personname><affiliation> <address><email>brucem@alumni.cse.ucsc.edu</email>
- </address> </affiliation></author>
+ <author><personname><firstname>Bruce</firstname><surname>Montague</surname></personname><affiliation> <default:address xmlns="http://docbook.org/ns/docbook"><email>brucem@alumni.cse.ucsc.edu</email>
+ </default:address> </affiliation></author>
</authorgroup>
So we get these errors when it breaks the build:
namespace error : Namespace prefix default on address is not defined
element default:address: validity error : No declaration for attribute xmlns of element default:address
element affiliation: validity error : Element affiliation content does not follow the DTD, expecting (shortaffil? , jobtitle* , (org? | (orgname? , orgdiv* , address*))), got (default:address )
...
Reinstalling itstool-2.0.2_2 fixed this.
That looks like an upstream change, rather than a problem with the upgrade. Would you be able to report it to the author? (In reply to Mikhail T. from comment #12) Sure, it's done. Thank you. Hi, this is still impacting the translation efforts of FreeBSD (2 months now), I'm willing to do a repocopy to textproc/itstool22 (v2.0.2) and then link textproc/docproj against it. Is that ok? I tested v2.0.6 and it gives us the same issue. Regards. A commit references this bug: Author: dbaio Date: Mon Jun 17 22:46:24 UTC 2019 New revision: 504444 URL: https://svnweb.freebsd.org/changeset/ports/504444 Log: Add textproc/itstool22 (v.2.0.2) This brings back ITS Tool 2.0.2 to the tree because there is an issue with version 2.0.5 and it is impacting the translation efforts of FreeBSD [1]. I'll keep this version until this problem gets fixed. 1 - https://github.com/itstool/itstool/issues/38 PR: 224903 Changes: head/textproc/Makefile head/textproc/itstool/Makefile head/textproc/itstool22/ head/textproc/itstool22/Makefile 2.0.6 already in ports, time to close this? |