Bug 224945

Summary: Ports maintained by kde@ broken by Clang 6
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: kde
Status: Closed FIXED    
Severity: Affects Only Me CC: kde, tcberner
Priority: --- Flags: tcberner: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 224669    

Description Jan Beich freebsd_committer 2018-01-06 01:40:45 UTC
FreeBSD -CURRENT plans to update base Clang to 6.0.0 soon. While testing some kde@ ports failed to build.

(In reply to Antoine Brodin from bug 224669 comment #4)
> + {"origin"=>"accessibility/qt4-accessible", "phase"=>"build", "errortype"=>"clang"}
> + {"origin"=>"deskutils/libstreamanalyzer", "phase"=>"build", "errortype"=>"bad_C++_code"}
> + {"origin"=>"devel/qt4-script", "phase"=>"build", "errortype"=>"???"}
> + {"origin"=>"net/cagibi", "phase"=>"build", "errortype"=>"???"}
> + {"origin"=>"textproc/soprano", "phase"=>"build", "errortype"=>"???"}
> + {"origin"=>"x11-toolkits/attica", "phase"=>"build", "errortype"=>"???"}
> + {"origin"=>"x11/qimageblitz", "phase"=>"build", "errortype"=>"clang"}

To reproduce:
$ poudriere jail -cj clang6-amd64 -a amd64 -v projects/clang600-import -m svn+https
$ poudriere bulk -Ctj clang6-amd64 accessibility/qt4-accessible ...
Comment 2 Jan Beich freebsd_committer 2018-01-06 04:16:31 UTC
devel/qt4-script blocks 183 ports.
deskutils/libstreamanalyzer blocks 4 ports.
Comment 3 commit-hook freebsd_committer 2018-01-06 18:39:28 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 18:39:21 UTC 2018
New revision: 458285
URL: https://svnweb.freebsd.org/changeset/ports/458285

Log:
  net/cagibi fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/net/cagibi/Makefile
  head/net/cagibi/files/
  head/net/cagibi/files/patch-daemon_ssdpwatcher.cpp
Comment 4 commit-hook freebsd_committer 2018-01-06 18:49:38 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 18:48:33 UTC 2018
New revision: 458286
URL: https://svnweb.freebsd.org/changeset/ports/458286

Log:
  x11/qimageblitz, fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/x11/qimageblitz/Makefile
Comment 5 Tobias C. Berner freebsd_committer 2018-01-06 19:08:58 UTC
qt4-script probably needs parts of:
https://gitorious.org/qt/qtscript/commit/15bb30b0e90c628cc3812627923d1d459d461505
Comment 6 commit-hook freebsd_committer 2018-01-06 22:03:29 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 22:02:47 UTC 2018
New revision: 458295
URL: https://svnweb.freebsd.org/changeset/ports/458295

Log:
  x11-toolkits/attica fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/x11-toolkits/attica/Makefile
Comment 7 commit-hook freebsd_committer 2018-01-06 22:07:35 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 22:07:15 UTC 2018
New revision: 458296
URL: https://svnweb.freebsd.org/changeset/ports/458296

Log:
  accessiblity/qt4-accessbile, fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/accessibility/qt4-accessible/Makefile
Comment 8 commit-hook freebsd_committer 2018-01-06 22:12:41 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 22:11:58 UTC 2018
New revision: 458297
URL: https://svnweb.freebsd.org/changeset/ports/458297

Log:
  devel/qt4-script, fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/devel/qt4-script/Makefile
Comment 9 commit-hook freebsd_committer 2018-01-06 22:34:00 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 22:33:13 UTC 2018
New revision: 458298
URL: https://svnweb.freebsd.org/changeset/ports/458298

Log:
  textproc/soprano, fix build with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/textproc/soprano/Makefile
  head/textproc/soprano/files/
  head/textproc/soprano/files/patch-soprano_pluginmanager.cpp
  head/textproc/soprano/files/patch-soprano_sopranodirs.cpp
Comment 10 commit-hook freebsd_committer 2018-01-06 23:04:27 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan  6 23:03:49 UTC 2018
New revision: 458300
URL: https://svnweb.freebsd.org/changeset/ports/458300

Log:
  desekutils/libstreamanalyzer fix with clang6

  PR:		224945
  Reported by:	jbeich

Changes:
  head/deskutils/libstreamanalyzer/Makefile
Comment 11 Tobias C. Berner freebsd_committer 2018-01-06 23:05:29 UTC
OK, that should be all the ones you mentioned. 

I run a build of qt4-script&libstreamanalyzers children over night, and fix the fallout tommorrow.
Comment 12 commit-hook freebsd_committer 2018-01-07 09:28:10 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 09:27:12 UTC 2018
New revision: 458309
URL: https://svnweb.freebsd.org/changeset/ports/458309

Log:
  multimedia/gstreamer-qt4, fix build with clang6

  PR:		224945

Changes:
  head/multimedia/gstreamer-qt4/Makefile
  head/multimedia/gstreamer-qt4/files/
  head/multimedia/gstreamer-qt4/files/patch-elements_gstqtvideosink_gstqtvideosinkbase.cpp
  head/multimedia/gstreamer-qt4/files/patch-elements_gstqtvideosink_qtvideosinkdelegate.cpp
  head/multimedia/gstreamer-qt4/files/patch-elements_gstqtvideosink_qwidgetvideosinkdelegate.cpp
Comment 13 commit-hook freebsd_committer 2018-01-07 09:28:12 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 09:27:51 UTC 2018
New revision: 458310
URL: https://svnweb.freebsd.org/changeset/ports/458310

Log:
  www/qt4-webkit, fix build with clang6

  PR:		224945

Changes:
  head/www/qt4-webkit/Makefile
Comment 14 commit-hook freebsd_committer 2018-01-07 10:08:47 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 10:08:23 UTC 2018
New revision: 458311
URL: https://svnweb.freebsd.org/changeset/ports/458311

Log:
  x11-toolkits/qt5-gui, fix build with clang 6

  PR:		224945
  Submitted by:	jbeich
  Reported by:	jbeich

Changes:
  head/x11-toolkits/qt5-gui/Makefile
Comment 15 commit-hook freebsd_committer 2018-01-07 10:09:50 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 10:08:50 UTC 2018
New revision: 458312
URL: https://svnweb.freebsd.org/changeset/ports/458312

Log:
  graphics/qt5-imageformats, fix build with clang6

  PR:		224945

Changes:
  head/graphics/qt5-imageformats/Makefile
Comment 16 commit-hook freebsd_committer 2018-01-07 11:58:22 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 11:57:51 UTC 2018
New revision: 458314
URL: https://svnweb.freebsd.org/changeset/ports/458314

Log:
  x11/kdelibs4 fix build with clang6

  PR:		224945

Changes:
  head/x11/kdelibs4/Makefile
  head/x11/kdelibs4/files/patch-dnssd_servicemodel.cpp
  head/x11/kdelibs4/files/patch-kdeui_icons_kiconcache.cpp
  head/x11/kdelibs4/files/patch-khtml_misc_AtomicString.cpp
  head/x11/kdelibs4/files/patch-khtml_xml_dom__stringimpl.h
  head/x11/kdelibs4/files/patch-kinit_kinit.cpp
Comment 17 commit-hook freebsd_committer 2018-01-07 14:31:26 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 14:30:45 UTC 2018
New revision: 458337
URL: https://svnweb.freebsd.org/changeset/ports/458337

Log:
  devel/py-pykde4, fix build with clang6

  PR:		224945

Changes:
  head/devel/py-pykde4/Makefile
Comment 18 commit-hook freebsd_committer 2018-01-07 15:03:55 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 15:03:16 UTC 2018
New revision: 458340
URL: https://svnweb.freebsd.org/changeset/ports/458340

Log:
  devel/smokeqt fix build with clang6

  PR:		224945

Changes:
  head/devel/smokeqt/Makefile
Comment 19 commit-hook freebsd_committer 2018-01-07 17:03:31 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 17:02:46 UTC 2018
New revision: 458360
URL: https://svnweb.freebsd.org/changeset/ports/458360

Log:
  deskutils/superkaramba, fix with clang6

  PR:		224945

Changes:
  head/deskutils/superkaramba/Makefile
Comment 20 commit-hook freebsd_committer 2018-01-07 17:08:37 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 17:07:47 UTC 2018
New revision: 458361
URL: https://svnweb.freebsd.org/changeset/ports/458361

Log:
  net-p2p/libktorrent, fix with clang6

  PR:		224945
  Submitted by:	rakuco

Changes:
  head/net-p2p/libktorrent/Makefile
  head/net-p2p/libktorrent/files/
  head/net-p2p/libktorrent/files/patch-src_diskio_chunkmanager.cpp
Comment 21 commit-hook freebsd_committer 2018-01-07 18:17:35 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 18:16:48 UTC 2018
New revision: 458364
URL: https://svnweb.freebsd.org/changeset/ports/458364

Log:
  games/bovo, fix build with clang6

  PR:		224945

Changes:
  head/games/bovo/Makefile
Comment 22 commit-hook freebsd_committer 2018-01-07 18:18:38 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 18:17:31 UTC 2018
New revision: 458365
URL: https://svnweb.freebsd.org/changeset/ports/458365

Log:
  devel/p5-perlqt, fix build with clang6

  PR:		224945

Changes:
  head/devel/p5-perlqt/Makefile
Comment 23 commit-hook freebsd_committer 2018-01-07 18:18:40 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 18:18:30 UTC 2018
New revision: 458366
URL: https://svnweb.freebsd.org/changeset/ports/458366

Log:
  sysutils/kuser, fix build with clang6

  PR:		224945

Changes:
  head/sysutils/kuser/Makefile
  head/sysutils/kuser/files/patch-globals.h
Comment 24 commit-hook freebsd_committer 2018-01-07 18:20:44 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 18:19:47 UTC 2018
New revision: 458367
URL: https://svnweb.freebsd.org/changeset/ports/458367

Log:
  devel/smokekde, fix build with clang6

  PR:		224945

Changes:
  head/devel/smokekde/Makefile
Comment 25 commit-hook freebsd_committer 2018-01-07 18:21:47 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan  7 18:21:30 UTC 2018
New revision: 458368
URL: https://svnweb.freebsd.org/changeset/ports/458368

Log:
  net-im/kopete-kde4, fix build with clang6

  PR:		224945

Changes:
  head/net-im/kopete-kde4/Makefile
Comment 26 commit-hook freebsd_committer 2018-01-07 21:54:15 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jan  7 21:53:15 UTC 2018
New revision: 458386
URL: https://svnweb.freebsd.org/changeset/ports/458386

Log:
  Fix the build on i386 with clang 6.0.

  kernel/qx11embed_x11.cpp:486:20: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'long' in initializer list [-Wc++11-narrowing]
      long data[] = {XEMBED_VERSION, XEMBED_MAPPED};
                     ^~~~~~~~~~~~~~
  kernel/qx11embed_x11.cpp:486:20: note: insert an explicit cast to silence this issue
      long data[] = {XEMBED_VERSION, XEMBED_MAPPED};
                     ^~~~~~~~~~~~~~
                     static_cast<long>( )

  PR:		224945

Changes:
  head/x11-toolkits/qt4-gui/files/
  head/x11-toolkits/qt4-gui/files/patch-src_gui_kernel_qx11embed__x11.cpp
Comment 27 Jan Beich freebsd_committer 2018-01-08 14:22:05 UTC
(In reply to commit-hook from comment #16)
x11/kdelibs4 still fails on i386:

kdeui/util/kpixmapcache.cpp:1180:88: error: non-constant-expression cannot be narrowed from type 'quint32' (aka 'unsigned int') to 'time_t' (aka 'int') in initializer list [-Wc++11-narrowing]
    KPixmapCacheIndexHeader indexHeader = { {0}, KPIXMAPCACHE_VERSION, 0, d->mCacheId, d->mTimestamp };
                                                                                       ^~~~~~~~~~~~~
kdeui/util/kpixmapcache.cpp:1180:88: note: insert an explicit cast to silence this issue
    KPixmapCacheIndexHeader indexHeader = { {0}, KPIXMAPCACHE_VERSION, 0, d->mCacheId, d->mTimestamp };
                                                                                       ^~~~~~~~~~~~~
                                                                                       static_cast<time_t>( )

http://package18.nyi.freebsd.org/data/headi386PR224669-default/2018-01-07_22h53m03s/logs/errors/kdelibs-4.14.30_7.log
Comment 28 commit-hook freebsd_committer 2018-01-08 17:42:26 UTC
A commit references this bug:

Author: tcberner
Date: Mon Jan  8 17:41:58 UTC 2018
New revision: 458460
URL: https://svnweb.freebsd.org/changeset/ports/458460

Log:
  x11/kdelibs4, fix build on i386 with clang6

  The previous fixes in r458314 were not enough for i386.
  Backport fix from x11/kf5-kdelibs4support.

  PR:		224945

Changes:
  head/x11/kdelibs4/Makefile
  head/x11/kdelibs4/files/patch-git_071caf
Comment 29 commit-hook freebsd_committer 2018-01-09 20:54:04 UTC
A commit references this bug:

Author: rakuco
Date: Tue Jan  9 20:53:24 UTC 2018
New revision: 458571
URL: https://svnweb.freebsd.org/changeset/ports/458571

Log:
  Explicitly build with -std=gnu++98

  clang 6.0 will default to -std=gnu++14, which breaks the build:

      /wrkdirs/usr/ports/math/rocs/work/rocs-4.14.3/VisualEditor/Actions/SelectMoveHandAction.cpp:86:52: error: no viable conversion from 'int' to 'QPainter::RenderHints' (aka 'QFlags<QPainter::RenderHint>')
              _graphScene->views().at(0)->setRenderHints(QPainter::Antialiasing

  PR:		224945

Changes:
  head/math/rocs/Makefile
Comment 30 commit-hook freebsd_committer 2018-01-09 21:05:15 UTC
A commit references this bug:

Author: rakuco
Date: Tue Jan  9 21:04:44 UTC 2018
New revision: 458573
URL: https://svnweb.freebsd.org/changeset/ports/458573

Log:
  Backport a patch to fix the build with -std=gnu++14.

  clang 6.0 defaults to -std=gnu++14 instead of -std=gnu++98. This backport fixes
  the following error:

      /wrkdirs/usr/ports/devel/py-krosspython/work/kross-interpreters-4.14.3/python/cxx/Objects.hxx:1081:15: error: cannot initialize a member subobject of type 'int' with an rvalue of type 'nullptr_t'
                  , offset( NULL )
                    ^       ~~~~

  PR:		224945

Changes:
  head/devel/py-krosspython/files/
  head/devel/py-krosspython/files/patch-git_81e17bf
Comment 31 commit-hook freebsd_committer 2018-01-09 21:48:55 UTC
A commit references this bug:

Author: rakuco
Date: Tue Jan  9 21:47:56 UTC 2018
New revision: 458577
URL: https://svnweb.freebsd.org/changeset/ports/458577

Log:
  Explicitly build with -std=gnu++98.

  clang 6.0 defaults to -std=gnu++14, but the port fails with too many errors
  when built in C++11 (or later) mode.

  PR:		224945

Changes:
  head/x11/kde4-workspace/Makefile
Comment 32 Raphael Kubo da Costa freebsd_committer 2018-01-14 13:14:41 UTC
As far as I can see all ports we maintain are now working with clang 6.0, so it's time to close this bug.
Comment 33 commit-hook freebsd_committer 2018-01-15 17:17:24 UTC
A commit references this bug:

Author: rakuco
Date: Mon Jan 15 17:16:27 UTC 2018
New revision: 459089
URL: https://svnweb.freebsd.org/changeset/ports/459089

Log:
  Backport a patch to fix the build with clang 6.0.

      /wrkdirs/usr/ports/net-p2p/ktorrent/work/ktorrent-4.3.1/libktcore/torrent/chunkbarrenderer.cpp:68:16: error: non-constant-expression cannot be narrowed from type 'bt::Uint32' (aka 'unsigned int') to 'int' in initializer list [-Wc++11-narrowing]

  PR:		224945
  Reported by:	pkg-fallout

Changes:
  head/net-p2p/ktorrent/files/patch-git_48622603
Comment 34 commit-hook freebsd_committer 2018-01-16 13:27:26 UTC
A commit references this bug:

Author: rakuco
Date: Tue Jan 16 13:26:44 UTC 2018
New revision: 459167
URL: https://svnweb.freebsd.org/changeset/ports/459167

Log:
  Fix the build with clang 6.0, which defaults to using -std=gnu++14.

      /wrkdirs/usr/ports/graphics/digikam-kde4/work/digikam-4.14.0/core/libs/dimg/loaders/pgfloader.cpp:301:27: error: use of undeclared identifier 'NULL'
                                NULL,
                                ^
      /usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
      #define NULL    nullptr
                      ^
      /usr/local/include/libpgf/PGFplatform.h:488:20: note: expanded from macro 'nullptr'
      #define nullptr                         NULL
                                              ^
      /wrkdirs/usr/ports/graphics/digikam-kde4/work/digikam-4.14.0/core/libs/dimg/loaders/pgfloader.cpp:461:26: error: use of undeclared identifier 'NULL'
                               NULL,
                               ^
      /usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
      #define NULL    nullptr
                      ^
      /usr/local/include/libpgf/PGFplatform.h:488:20: note: expanded from macro 'nullptr'
      #define nullptr                         NULL
                                              ^

  PR:		224945

Changes:
  head/graphics/digikam-kde4/files/patch-libs_dimg_loaders_pgfloader.cpp
Comment 35 commit-hook freebsd_committer 2018-01-20 23:59:39 UTC
A commit references this bug:

Author: rakuco
Date: Sat Jan 20 23:58:54 UTC 2018
New revision: 459558
URL: https://svnweb.freebsd.org/changeset/ports/459558

Log:
  Backport a few upstream patches to fix the build with clang 6 (-std=gnu++14)

  PR:		224945

Changes:
  head/sysutils/k3b-kde4/files/patch-git_1777236
  head/sysutils/k3b-kde4/files/patch-git_d5b1016
Comment 36 commit-hook freebsd_committer 2018-01-21 18:37:00 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jan 21 18:35:57 UTC 2018
New revision: 459623
URL: https://svnweb.freebsd.org/changeset/ports/459623

Log:
  Fix one of the patches added in r459558.

  PR:		224945
  Reported by:	antoine

Changes:
  head/sysutils/k3b-kde4/files/patch-git_d5b1016